Wait for RefreshJob before waiting on indexer in ModifyingResourceTests.createFile()#5067
Merged
Merged
Conversation
…ts.createFile() Latest test logs from failures in JavaSearchBugsTests2 show that RefreshJob can request indexing of test files in parallel to the main thread. Likely the RefreshJob picks up the delta first and the main thread finishes waiting before the indexing request is sent by RefreshJob. This change adds waiting on RefreshJob before waiting on indexing, to hopefully prevent the test from not waiting on the index request. See: eclipse-jdt#421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest test logs from failures in
JavaSearchBugsTests2show thatRefreshJobcan request indexing of test files in parallel to the main thread. Likely theRefreshJobpicks up the delta first and the main thread finishes waiting before the indexing request is sent byRefreshJob.This change adds waiting on
RefreshJobbefore waiting on indexing, to hopefully prevent the test from not waiting on the index request.See: #421