Skip to content

Wait for RefreshJob before waiting on indexer in ModifyingResourceTests.createFile() #5067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trancexpress merged 1 commit into from
May 15, 2026
Merged

Wait for RefreshJob before waiting on indexer in ModifyingResourceTests.createFile() #5067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...pse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ModifyingResourceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ protected void createExternalFile(String relativePath, String contents) {
protected IFile createFile(String path, byte[] content) throws CoreException {
IFile file = super.createFile(path, content);
if(!isIndexDisabledForTest()) {
/*
* Its possible that the RefreshJob picks up the file delta and requests indexing,
* instead of the main thread (in which tests run). Make sure we don't miss that index request in the wait below.
*/
waitForAutoRefresh();
JavaModelManager.getIndexManager().waitForIndex(false, null);
}
return file;
Expand Down
Loading