Skip to content

Clean Code for bundles/org.eclipse.ui.monitoring#3314

Merged
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.ui.monitoring
Sep 24, 2025
Merged

Clean Code for bundles/org.eclipse.ui.monitoring#3314
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.ui.monitoring

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 23, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.monitoring/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b4b57370e7dbf5463973f11184ebcdc795f9bff6 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 24 Sep 2025 04:07:21 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.ui.monitoring/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.monitoring/META-INF/MANIFEST.MF
index daf7dc1df9..2853fd6ee6 100644
--- a/bundles/org.eclipse.ui.monitoring/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.monitoring/META-INF/MANIFEST.MF
@@ -6,7 +6,7 @@ Bundle-Name: %Bundle-Name
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Bundle-SymbolicName: org.eclipse.ui.monitoring;singleton:=true
 Bundle-Vendor: %Bundle-Vendor
-Bundle-Version: 1.3.400.qualifier
+Bundle-Version: 1.3.500.qualifier
 Export-Package: org.eclipse.ui.internal.monitoring;x-internal:=true,
  org.eclipse.ui.internal.monitoring.preferences;x-internal:=true,
  org.eclipse.ui.monitoring;x-internal:=true
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 23, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 10m 31s ⏱️ + 5m 51s
 8 019 tests ±0   7 774 ✅ ±0  245 💤 ±0  0 ❌ ±0 
23 591 runs  ±0  22 809 ✅ ±0  782 💤 ±0  0 ❌ ±0 

Results for commit e82504a. ± Comparison against base commit 422bd8b.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.ui.monitoring branch from 5b98833 to 695ac8f Compare September 24, 2025 04:02
@akurtakov akurtakov merged commit 28f12e7 into master Sep 24, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.ui.monitoring branch September 24, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants