Skip to content

Clean Code for bundles/org.eclipse.ui.monitoring #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 2 commits into from
Sep 24, 2025
Merged

Clean Code for bundles/org.eclipse.ui.monitoring #3314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
695ac8f
Perform clean code of bundles/org.eclipse.ui.monitoring
eclipse-platform-bot Sep 24, 2025
e82504a
Version bump(s) for 4.38 stream
eclipse-platform-bot Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.ui.monitoring/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Bundle-Name: %Bundle-Name
Bundle-RequiredExecutionEnvironment: JavaSE-17
Bundle-SymbolicName: org.eclipse.ui.monitoring;singleton:=true
Bundle-Vendor: %Bundle-Vendor
Bundle-Version: 1.3.400.qualifier
Bundle-Version: 1.3.500.qualifier
Export-Package: org.eclipse.ui.internal.monitoring;x-internal:=true,
org.eclipse.ui.internal.monitoring.preferences;x-internal:=true,
org.eclipse.ui.monitoring;x-internal:=true
Expand Down
3 changes: 1 addition & 2 deletions ...ipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/DefaultUiFreezeEventLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,7 @@ private static IStatus createThreadStatus(ThreadInfo thread) {
} else {
threadText.append(NLS.bind(
Messages.DefaultUiFreezeEventLogger_waiting_for_with_lock_owner_3,
new Object[] { getClassAndHashCode(lock), lockOwnerName,
thread.getLockOwnerId() }));
getClassAndHashCode(lock), lockOwnerName, thread.getLockOwnerId()));
}
}

Expand Down
6 changes: 2 additions & 4 deletions ....eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/EventLoopMonitorThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ private class EventLoopState implements Listener {
* {@link SWT#PreExternalEventDispatch PreExternalEventDispatch} event and popped from
* the stack on {@link SWT#PostExternalEventDispatch PostExternalEventDispatch} event.
*/
private int[] nestingLevelStack = new int[64];
private final int[] nestingLevelStack = new int[64];
private int nestingLevelStackSize;

@Override
Expand Down Expand Up @@ -727,9 +727,7 @@ private void loadLoggerExtensions() {
} else {
MonitoringPlugin.logWarning(NLS.bind(
Messages.EventLoopMonitorThread_invalid_logger_type_error_4,
new Object[] { object.getClass().getName(),
IUiFreezeEventLogger.class.getClass().getSimpleName(),
EXTENSION_ID, element.getContributor().getName() }));
object.getClass().getName(), IUiFreezeEventLogger.class.getClass().getSimpleName(), EXTENSION_ID, element.getContributor().getName()));
}
} catch (CoreException e) {
MonitoringPlugin.logError(e.getMessage(), e);
Expand Down
2 changes: 1 addition & 1 deletion ...se.ui.monitoring/src/org/eclipse/ui/internal/monitoring/preferences/FilterListEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
* Displays the list of stack frames used as a filter.
*/
public class FilterListEditor extends ListEditor {
private String dialogMessage;
private final String dialogMessage;

FilterListEditor(String name, String label, String addButtonLabel, String removeButtonLabel,
String dialogMessage, Composite parent) {
Expand Down
2 changes: 1 addition & 1 deletion ...nitoring/src/org/eclipse/ui/internal/monitoring/preferences/MonitoringPreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class MonitoringPreferencePage extends FieldEditorPreferencePage
private IntegerEditor longEventWarningThreshold;
private IntegerEditor longEventErrorThreshold;
private IntegerEditor deadlockThreshold;
private Map<FieldEditor, Composite> editors;
private final Map<FieldEditor, Composite> editors;

private class IntegerEditor extends IntegerFieldEditor {
public IntegerEditor(String name, String labelText, Composite parent, int min, int max) {
Expand Down
Loading