Remove document listener from *old* document on setDocument()#3384
Merged
Conversation
Contributor
UpdateDocumentListener is added to document but not always removed in ProjectionViewer, regression introduced by commit eclipse-platform@1848058 This fixes remaining possible leak, where *multiple* documents were used in ProjectionViewer. See eclipse-jdt/eclipse.jdt.ui#2532
iloveeclipse
force-pushed
the
issue_2532
branch
from
a0adce5 to
1bb8a4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateDocumentListener is added to document but not always removed in ProjectionViewer, regression introduced by commit 1848058
This fixes remaining possible leak, where multiple documents were used in ProjectionViewer.
See eclipse-jdt/eclipse.jdt.ui#2532