Skip to content

Remove document listener from *old* document on setDocument() #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iloveeclipse merged 1 commit into from
Oct 9, 2025
Merged

Remove document listener from *old* document on setDocument() #3384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions ...ipse.jface.text/projection/org/eclipse/jface/text/source/projection/ProjectionViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ public void setDocument(IDocument document, IAnnotationModel annotationModel, in
}

if (fProjectionAnnotationModel != null) {
removeDocumentUpdateListener();
wasProjectionEnabled= removeProjectionAnnotationModel(getVisualAnnotationModel()) != null;
fProjectionAnnotationModel= null;
}
Expand All @@ -413,6 +414,15 @@ public void setDocument(IDocument document, IAnnotationModel annotationModel, in

}

private void removeDocumentUpdateListener() {
if (fUpdateDocumentListener != null) {
IDocument document= getDocument();
if (document != null) {
document.removeDocumentListener(fUpdateDocumentListener);
}
}
}

@Override
protected IAnnotationModel createVisualAnnotationModel(IAnnotationModel annotationModel) {
IAnnotationModel model= super.createVisualAnnotationModel(annotationModel);
Expand Down Expand Up @@ -554,10 +564,7 @@ public final void disableProjection() {
super.setVisibleRegion(fVisibleRegionDuringProjection.getOffset(), fVisibleRegionDuringProjection.getLength());
fVisibleRegionDuringProjection= null;
}
IDocument document= getDocument();
if (document != null) {
document.removeDocumentListener(fUpdateDocumentListener);
}
removeDocumentUpdateListener();
}
}

Expand Down Expand Up @@ -1480,12 +1487,7 @@ private boolean willAutoExpand(Position position, int offset, int length) {
@Override
protected void handleDispose() {
fWasProjectionEnabled= false;
if (fUpdateDocumentListener != null) {
IDocument document= getDocument();
if (document != null) {
document.removeDocumentListener(fUpdateDocumentListener);
}
}
removeDocumentUpdateListener();
super.handleDispose();
}

Expand Down
Loading