fix: Change default branch and reviewer in update-geolite workflow#34
fix: Change default branch and reviewer in update-geolite workflow#34robrap wants to merge 8 commits intorelease-ulmofrom
Conversation
Update from master => release-ulmo, and feanil => orbi-bom.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GeoLite database update workflow to target the release-ulmo branch instead of master and changes the default PR reviewer from feanil to orbi-bom. This aligns the workflow with the current named release branch strategy.
Key Changes:
- Updated default target branch from
mastertorelease-ulmo - Changed PR reviewer from
feaniltoorbi-bom
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --head $BRANCH \ | ||
| --base 'master' \ | ||
| --reviewer 'feanil' \ | ||
| --base 'release-ulmo' \ |
There was a problem hiding this comment.
The branch input parameter defined at line 8-11 is not being used here. The --base flag should use ${{ inputs.branch || 'release-ulmo' }} instead of hardcoding 'release-ulmo', or the input parameter should be removed if it's not needed. Currently, if someone manually triggers this workflow with a different branch, it will be ignored.
| --base 'release-ulmo' \ | |
| --base '${{ inputs.branch || 'release-ulmo' }}' \ |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amits-2u
force-pushed
the
robrap/update-geolite
branch
from
02d0e06 to
dd9e741
Compare
| PR_NUMBER=$(echo "$PR_URL" | grep -o '[0-9]*$') | ||
| curl -X POST \ | ||
| -H "Authorization: token $GH_TOKEN" \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| https://api.github.com/repos/edx/edx-platform/pulls/$PR_NUMBER/requested_reviewers \ | ||
| -d '{"team_reviewers":["orbi-bom"]}' | ||
|
|
There was a problem hiding this comment.
This couldn't be done by replacing the already existing -reviewer 'feanil'? What happened?
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ktyagiapphelix2u
force-pushed
the
robrap/update-geolite
branch
from
c4a6bc8 to
5bce80a
Compare
Description
Update update-geolite workflow from master => release-ulmo, and feanil => orbi-bom.
Each named release will need to make an update. This should go on our Verawood doc.