Skip to content

fix: Change default branch and reviewer in update-geolite workflow #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robrap wants to merge 8 commits into from
Closed

fix: Change default branch and reviewer in update-geolite workflow #34

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
046a45e
fix: Change default branch and reviewer in update-geolite workflow
robrap Nov 13, 2025
52608ca
fix: Change default branch and reviewer in update-geolite workflow
ktyagiapphelix2u Nov 14, 2025
1dd2a42
fix: change PR reviewer from ktyagiapphelix2u to orbi-bom
amits-2u Nov 14, 2025
812b152
fix: change reviewer to team-reviewer in workflow
amits-2u Nov 14, 2025
dd9e741
fix: adding orbi-bom as team reviewers
amits-2u Nov 14, 2025
178b2ed
fix: Change default branch and reviewer in update-geolite workflow
ktyagiapphelix2u Nov 18, 2025
e0a5b96
fix: Change default branch and reviewer in update-geolite workflow
ktyagiapphelix2u Nov 18, 2025
5bce80a
fix: Change default branch and reviewer in update-geolite workflow
ktyagiapphelix2u Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/update-geolite-database.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
branch:
description: "Target branch against which to create PR"
required: false
default: "master"
default: "release-ulmo"

env:
MAXMIND_URL: "https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-Country&license_key=${{ secrets.MAXMIND_LICENSE_KEY }}&suffix=tar.gz"
Expand Down Expand Up @@ -79,11 +79,12 @@ jobs:
--title "Update GeoLite Database" \
--body "PR generated by workflow `${{ github.workflow }}` on behalf of @${{ github.actor }}." \
--head $BRANCH \
--base 'master' \
--reviewer 'feanil' \
--base 'release-ulmo' \
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch input parameter defined at line 8-11 is not being used here. The --base flag should use ${{ inputs.branch || 'release-ulmo' }} instead of hardcoding 'release-ulmo', or the input parameter should be removed if it's not needed. Currently, if someone manually triggers this workflow with a different branch, it will be ignored.

Suggested change
--base 'release-ulmo' \
--base '${{ inputs.branch || 'release-ulmo' }}' \

Copilot uses AI. Check for mistakes.
--reviewer edx/orbi-bom \
| grep -o 'https://github.com/.*/pull/[0-9]*')
echo "PR Created: ${PR_URL}"
echo "pull-request-url=$PR_URL" >> $GITHUB_OUTPUT

env:
GH_TOKEN: ${{ github.token }}

Expand Down
Loading