Aut 90 logistration stage registration and sign in pages are misaligned and not following the expected layout style#7
Conversation
…rprise-theming Aut 17 update auth mfe to support enterprise theming
There was a problem hiding this comment.
Pull request overview
Fixes alignment inconsistencies in the new authn MFE by standardizing the .content container class usage inside BaseContainer.
Changes:
- Removed
classnamesusage fromBaseContainerand stopped conditionally addingalign-items-center mt-0whenshowWelcomeBanneris true. - Standardized both layout branches (image layout + default layout) to render
<div className="content">.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div className="content"> | ||
| {children} | ||
| </div> |
There was a problem hiding this comment.
This change removes the showWelcomeBanner-specific spacing/alignment classes from the shared BaseContainer. BaseContainer is also used outside the Register/Sign-in flows (e.g., ProgressiveProfiling passes showWelcomeBanner), so this will change layout in those screens too; please confirm this is intended or scope the styling change to only the logistration pages (e.g., via a dedicated prop or wrapper class).
| <div className="content"> | ||
| {children} | ||
| </div> |
There was a problem hiding this comment.
BaseContainer has unit tests, but none cover the showWelcomeBanner=true case that this PR changes (previously additional utility classes were applied). Consider adding a test that renders BaseContainer with showWelcomeBanner and asserts the resulting .content classes/structure so unintended layout regressions are caught.
ssurendrannair
deleted the
AUT-90-logistration-stage-registration-and-sign-in-pages-are-misaligned-and-not-following-the-expected-layout-style
branch
Alignment issue fixed for both Register and Sign in page in New authn MFE.