forked from openedx/frontend-app-authn
-
Notifications
You must be signed in to change notification settings - Fork 1
Aut 90 logistration stage registration and sign in pages are misaligned and not following the expected layout style #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ssurendrannair
merged 11 commits into
release-ulmo
from
AUT-90-logistration-stage-registration-and-sign-in-pages-are-misaligned-and-not-following-the-expected-layout-style
Feb 27, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
61573be
Merge pull request #4 from edx/AUT-17-update-auth-mfe-to-support-ente…
ssurendrannair c7f3b09
feat: frontend changes for enterprise theming
ssurendrannair 47d5ba4
fix: code changes for passing tests
ssurendrannair f8aecd1
fix: code changes for passing tests
ssurendrannair ca9381f
fix: code changes for passing tests
ssurendrannair 525490d
fix: code changes for passing tests
ssurendrannair 540f0de
fix: code changes for passing tests
ssurendrannair b263afe
fix: code changes for passing tests
ssurendrannair f596838
fix: code changes for passing tests
ssurendrannair c9111cd
Merge branch 'release-ulmo' of https://github.com/edx/frontend-app-au…
ssurendrannair eedfeb4
fix: alignment fixed for enterprise logistration
ssurendrannair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ import React from 'react'; | |
|
|
||
| import { getConfig } from '@edx/frontend-platform'; | ||
| import { breakpoints } from '@openedx/paragon'; | ||
| import classNames from 'classnames'; | ||
| import PropTypes from 'prop-types'; | ||
| import MediaQuery from 'react-responsive'; | ||
|
|
||
|
|
@@ -30,7 +29,7 @@ const BaseContainer = ({ children, showWelcomeBanner, fullName }) => { | |
| <MediaQuery minWidth={breakpoints.extraLarge.minWidth}> | ||
| {showWelcomeBanner ? <AuthLargeLayout fullName={fullName} /> : <ImageLargeLayout />} | ||
| </MediaQuery> | ||
| <div className={classNames('content', { 'align-items-center mt-0': showWelcomeBanner })}> | ||
| <div className="content"> | ||
| {children} | ||
| </div> | ||
| </div> | ||
|
|
@@ -50,7 +49,7 @@ const BaseContainer = ({ children, showWelcomeBanner, fullName }) => { | |
| <MediaQuery minWidth={breakpoints.extraLarge.minWidth}> | ||
| {showWelcomeBanner ? <AuthLargeLayout fullName={fullName} /> : <DefaultLargeLayout />} | ||
| </MediaQuery> | ||
| <div className={classNames('content', { 'align-items-center mt-0': showWelcomeBanner })}> | ||
| <div className="content"> | ||
| {children} | ||
| </div> | ||
|
Comment on lines
+52
to
54
|
||
| </div> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change removes the showWelcomeBanner-specific spacing/alignment classes from the shared BaseContainer. BaseContainer is also used outside the Register/Sign-in flows (e.g., ProgressiveProfiling passes showWelcomeBanner), so this will change layout in those screens too; please confirm this is intended or scope the styling change to only the logistration pages (e.g., via a dedicated prop or wrapper class).