fix: update default title and improve styling#25
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the default XBlock title to align with the default game type and improves flashcard styling for better visual consistency and emphasis.
Changes:
- Changed default XBlock title from "Matching" to "Flashcards" to match the default game type
- Increased font-weight from 600 to 700 for flashcard titles to improve emphasis
- Added text-align: center and additional font properties to flashcards-start-title for better alignment and consistency
- Version bump from 1.0.9 to 1.0.10
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| setup.py | Bumped version from 1.0.9 to 1.0.10 to reflect this bug fix and style improvement |
| games/static/css/flashcards.css | Enhanced flashcard styling with bolder title font-weight and centered alignment with explicit font properties for the start screen title |
| games/games.py | Changed default title from MATCHING_TITLE to FLASHCARDS_TITLE to align with the default game type of flashcards |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .flashcards-start-title { | ||
| color: var(--primary-500, #00262B); | ||
| text-align: center; | ||
| font-family: Inter; |
There was a problem hiding this comment.
The font-family 'Inter' is already specified on the parent element '.gamesxblock-flashcards' at line 2, so this redundant declaration can be removed. Child elements inherit the font-family from their parent unless explicitly overridden.
| font-family: Inter; |
| text-align: center; | ||
| font-family: Inter; | ||
| font-size: 20px; | ||
| font-style: normal; |
There was a problem hiding this comment.
The 'font-style: normal' declaration is unnecessary as 'normal' is already the default value for font-style. This property only needs to be explicitly set when you want italic or oblique styles.
| font-style: normal; |
|
|
||
| title = String( | ||
| default=DEFAULT.MATCHING_TITLE, | ||
| default=DEFAULT.FLASHCARDS_TITLE, |
There was a problem hiding this comment.
The default title has been changed from DEFAULT.MATCHING_TITLE to DEFAULT.FLASHCARDS_TITLE. This change aligns the default title with the default game type (which is flashcards), but it will break the existing test in tests/test_games.py at line 58 which expects 'default_block.title == DEFAULT.MATCHING_TITLE'. The test assertion needs to be updated to 'assert default_block.title == DEFAULT.FLASHCARDS_TITLE' to reflect this change.
djoseph-apphelix
requested review from
papphelix,
pganesh-apphelix and
viv-helix
Description