Skip to content

fix: update default title and improve styling #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djoseph-apphelix merged 2 commits into from
Jan 23, 2026
Merged

fix: update default title and improve styling #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e4b81c
fix: update default title and improve styling
djoseph-apphelix Jan 22, 2026
5ec8d95
fix: handle test cases
djoseph-apphelix Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion games/games.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class GamesXBlock(XBlock):
"""

title = String(
default=DEFAULT.MATCHING_TITLE,
default=DEFAULT.FLASHCARDS_TITLE,
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default title has been changed from DEFAULT.MATCHING_TITLE to DEFAULT.FLASHCARDS_TITLE. This change aligns the default title with the default game type (which is flashcards), but it will break the existing test in tests/test_games.py at line 58 which expects 'default_block.title == DEFAULT.MATCHING_TITLE'. The test assertion needs to be updated to 'assert default_block.title == DEFAULT.FLASHCARDS_TITLE' to reflect this change.

Copilot uses AI. Check for mistakes.
scope=Scope.content,
help=_("The title of the block to be displayed in the xblock."),
)
Expand Down
5 changes: 4 additions & 1 deletion games/static/css/flashcards.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
.flashcards-title {
color: var(--primary-500, #00262B);
font-size: 24px;
font-weight: 600;
font-weight: 700;
line-height: 32px;
margin: 0;
}
Expand All @@ -52,7 +52,10 @@

.flashcards-start-title {
color: var(--primary-500, #00262B);
text-align: center;
font-family: Inter;
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-family 'Inter' is already specified on the parent element '.gamesxblock-flashcards' at line 2, so this redundant declaration can be removed. Child elements inherit the font-family from their parent unless explicitly overridden.

Suggested change
font-family: Inter;

Copilot uses AI. Check for mistakes.
font-size: 20px;
font-style: normal;
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'font-style: normal' declaration is unnecessary as 'normal' is already the default value for font-style. This property only needs to be explicitly set when you want italic or oblique styles.

Suggested change
font-style: normal;

Copilot uses AI. Check for mistakes.
font-weight: 500;
line-height: 28px;
}
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def package_data(pkg, roots):

setup(
name="edx-games",
version="1.0.9",
version="1.0.10",
description="Interactive games XBlock for Open edX - Create flashcards and matching games with image support",
author="edX",
author_email="edx@edx.org",
Expand Down
2 changes: 1 addition & 1 deletion tests/test_games.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def test_default_values(self):
user_id='test-user-id',
)
)
assert default_block.title == DEFAULT.MATCHING_TITLE
assert default_block.title == DEFAULT.FLASHCARDS_TITLE
assert default_block.display_name == DEFAULT.DISPLAY_NAME
assert default_block.game_type == DEFAULT.GAME_TYPE
assert default_block.cards == []
Expand Down