Skip to content

feat: Remove unnecessary file prefix check in expiring files notification#64

Merged
ttak-apphelix merged 1 commit intomasterfrom
ttak-apphelix/BOMS-398-remove-prefix-check
Apr 13, 2026
Merged

feat: Remove unnecessary file prefix check in expiring files notification#64
ttak-apphelix merged 1 commit intomasterfrom
ttak-apphelix/BOMS-398-remove-prefix-check

Conversation

@ttak-apphelix
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 13, 2026 11:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the retirement partner report script’s “expiring files” notification logic by removing the report filename prefix construction and the startswith(file_prefix) filtering, so deletion warnings can be applied to a broader set of files in partner folders.

Changes:

  • Removed construction of the report file_prefix used for filtering.
  • Removed the filename prefix guard that previously skipped non-matching files during expiring-file checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tubular/scripts/retirement_partner_report.py
Comment thread tubular/scripts/retirement_partner_report.py
@ttak-apphelix ttak-apphelix merged commit 29ad208 into master Apr 13, 2026
7 checks passed
@ttak-apphelix ttak-apphelix deleted the ttak-apphelix/BOMS-398-remove-prefix-check branch April 13, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants