Skip to content

feat: Remove unnecessary file prefix check in expiring files notification #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttak-apphelix merged 1 commit into from
Apr 13, 2026
Merged

feat: Remove unnecessary file prefix check in expiring files notification #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions tubular/scripts/retirement_partner_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,10 +437,6 @@ def _check_and_notify_about_expiring_files(config, enable_overdue_file_notificat
# Get external emails per partner using shared helper
external_emails = _get_partner_emails(drive, config)

# Check files in each partner folder
platform_name = config['partner_report_platform_name']
file_prefix = '{}_{}'.format(REPORTING_FILENAME_PREFIX, platform_name)

for partner in config['partner_folder_mapping']:
folder_id = config['partner_folder_mapping'][partner]

Comment thread
ttak-apphelix marked this conversation as resolved.
Expand All @@ -462,9 +458,6 @@ def _check_and_notify_about_expiring_files(config, enable_overdue_file_notificat
for file_info in files:
filename = file_info.get('name', '')

if not filename.startswith(file_prefix):
continue

created_time_str = file_info.get('createdTime')
if not created_time_str:
LOG('WARNING: File {} has no creation time, skipping'.format(filename))
Comment thread
ttak-apphelix marked this conversation as resolved.
Expand Down
Loading