You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A closed filter popover can still have active filters, so this left the trigger exposed to assistive technology as expanded even when the controlled popover was closed.
This changes aria-expanded to follow only the actual disclosure state supplied through isSelected.
Checklist
PR has been opened against the correct base branch (main)
👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?
@DevLikhith5 as mentioned on another PR, 3 things to note: let's limit open PRs, let's focus on issues marked as "help wanted" but because this is genuinely an issue that should likely have that label, I'll leave the PR open. It's hard to say when we get to the review though so I ask for your patience 🙏🏻 Next week our whole team will be unavailable.
Thanks for the feedback! I'll keep the open PRs limited and focus on "help wanted" issues going forward. No rush on the review, appreciate you keeping it open 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9692.
EuiFilterButtonwas usinghasActiveFiltersas a fallback foraria-expandedwhen rendered as a collapsible chevron button:A closed filter popover can still have active filters, so this left the trigger exposed to assistive technology as expanded even when the controlled popover was closed.
This changes
aria-expandedto follow only the actual disclosure state supplied throughisSelected.Checklist