Skip to content

[EuiFilterButton] Don't infer aria-expanded from hasActiveFilters#9707

Open
DevLikhith5 wants to merge 2 commits into
elastic:mainfrom
DevLikhith5:fix/filter-button-aria-expanded-9692
Open

[EuiFilterButton] Don't infer aria-expanded from hasActiveFilters#9707
DevLikhith5 wants to merge 2 commits into
elastic:mainfrom
DevLikhith5:fix/filter-button-aria-expanded-9692

Conversation

@DevLikhith5

Copy link
Copy Markdown
Contributor

Summary

Closes #9692.

EuiFilterButton was using hasActiveFilters as a fallback for aria-expanded when rendered as a collapsible chevron button:

const isExpanded = isCollapsible && (isSelected ?? hasActiveFilters);

A closed filter popover can still have active filters, so this left the trigger exposed to assistive technology as expanded even when the controlled popover was closed.

This changes aria-expanded to follow only the actual disclosure state supplied through isSelected.

Checklist

  • PR has been opened against the correct base branch (main)
  • Changelog entry added

@DevLikhith5 DevLikhith5 requested a review from a team as a code owner June 3, 2026 14:57
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?

@github-actions github-actions Bot added the community contribution (Don't delete - used for automation) label Jun 3, 2026
@weronikaolejniczak

Copy link
Copy Markdown
Contributor

@DevLikhith5 as mentioned on another PR, 3 things to note: let's limit open PRs, let's focus on issues marked as "help wanted" but because this is genuinely an issue that should likely have that label, I'll leave the PR open. It's hard to say when we get to the review though so I ask for your patience 🙏🏻 Next week our whole team will be unavailable.

@DevLikhith5

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback! I'll keep the open PRs limited and focus on "help wanted" issues going forward. No rush on the review, appreciate you keeping it open 🙏

@weronikaolejniczak

Copy link
Copy Markdown
Contributor

buildkite test this

@elasticmachine

Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

@elasticmachine

Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community contribution (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EuiFilterButton] EuiFilterButton should not infer aria-expanded from active filters

3 participants