Skip to content

[EuiFilterButton] Don't infer aria-expanded from hasActiveFilters #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DevLikhith5 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

[EuiFilterButton] Don't infer aria-expanded from hasActiveFilters #9707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d24cb6f
fix: don't infer aria-expanded from hasActiveFilters on EuiFilterButton
DevLikhith5 Jun 3, 2026
914632d
fix: rename changelog from issue number to PR number (9692 -> 9707)
DevLikhith5 Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eui/changelogs/upcoming/9707.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed `EuiFilterButton` to not infer `aria-expanded` from `hasActiveFilters` when rendered as a collapsible chevron button
2 changes: 1 addition & 1 deletion packages/eui/src/components/filter_group/filter_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export const EuiFilterButton: FunctionComponent<EuiFilterButtonProps> = ({
// assumption about type of usage based on icon usage
// requires manual override to apply correct aria attributes for more custom usages
const isCollapsible = !isToggle && iconType === 'chevronSingleDown';
const isExpanded = isCollapsible && (isSelected ?? hasActiveFilters);
const isExpanded = isCollapsible && isSelected;

const styles = useEuiMemoizedStyles(euiFilterButtonStyles);
const focusColorStyles = useEuiMemoizedStyles(_compressedButtonFocusColors);
Expand Down