Skip to content

[cisco_meraki_metrics] Fix API base URL param #15746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[cisco_meraki_metrics] Fix API base URL param #15746

wants to merge 3 commits into from
+8 −3

Conversation

@gpop63
Copy link
Contributor

@gpop63 gpop63 commented Oct 24, 2025

Proposed commit message

This PR fixes the api base url config param capitalization.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 marked this pull request as ready for review October 24, 2025 10:38
@gpop63 gpop63 requested a review from a team as a code owner October 24, 2025 10:38
@elasticmachine
Copy link

💚 Build Succeeded

History

ishleenk17
ishleenk17 reviewed Oct 24, 2025
View reviewed changes
packages/cisco_meraki_metrics/data_stream/device_health/manifest.yml
type: url
title: Meraki Dashboard API base URL
default: api.meraki.com
default: https://api.meraki.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this protocol appending required ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the meraki Go library fails to make requests without https://

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how was it previously working ? Or was the customer adding this from their side ?

@andrewkroh andrewkroh added Integration:cisco_meraki_metrics Cisco Meraki Metrics Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@mykola-elastic mykola-elastic mykola-elastic approved these changes

Assignees

No one assigned

Labels

Integration:cisco_meraki_metrics Cisco Meraki Metrics Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gpop63 @elasticmachine @ishleenk17 @mykola-elastic @andrewkroh