Skip to content

[cisco_meraki_metrics] Fix API base URL param #15746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −3
Open

[cisco_meraki_metrics] Fix API base URL param #15746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
173f9a0
fix base url param
gpop63 Oct 24, 2025
83f101a
fix pr id
gpop63 Oct 24, 2025
049d8e0
fix default api url
gpop63 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/cisco_meraki_metrics/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "0.4.2"
changes:
- description: Fix API base URL config parameter
type: bugfix
link: https://github.com/elastic/integrations/pull/15746
- version: "0.4.1"
changes:
- description: scale values in device channel utilization so they display correctly as percentages.
Expand Down
2 changes: 1 addition & 1 deletion packages/cisco_meraki_metrics/data_stream/device_health/agent/stream/stream.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
metricsets: ["device_health"]
apiBaseUrl: {{apiBaseUrl}}
apiBaseURL: {{apiBaseUrl}}
apiKey: {{apiKey}}
organizations:
{{#each organizations as |organization|}}
Expand Down
2 changes: 1 addition & 1 deletion packages/cisco_meraki_metrics/data_stream/device_health/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ streams:
- name: apiBaseUrl
type: url
title: Meraki Dashboard API base URL
default: api.meraki.com
default: https://api.meraki.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this protocol appending required ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the meraki Go library fails to make requests without https://

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how was it previously working ? Or was the customer adding this from their side ?

- name: period
type: text
title: Collection interval
Expand Down
2 changes: 1 addition & 1 deletion packages/cisco_meraki_metrics/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: 3.2.0
name: cisco_meraki_metrics
title: Cisco Meraki Metrics
version: 0.4.1
version: 0.4.2
description: Collect metrics from Cisco Meraki with Elastic Agent.
type: integration
categories:
Expand Down