-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Implement UI for history visibility acknowledgement. #31156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Implement UI for history visibility acknowledgement. #31156
Conversation
68ef636 to
27b11e4
Compare
|
I'm wondering if this would be better off as a floating alert above the UI - would conflict less with the identity reset dialog. |
|
@kaylendog this is a question for the design team. Where are the figma design for this banner? |
Here (for EW)! |
|
Opening this up for review, since I can't make any headway on the CI failures:
|
florianduros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each components in shared component has its own folder. imo RoomStatusBarHistoryVisible should be in packages/shared-components/src/room/RoomStatusBarHistoryVisible.
The RoomStatusBarHistoryVisible is missing at least a render test and a check that onClose is correctly binded.
...ared-components/src/room/RoomStatusBarHistoryVisible/RoomStatusBarHistoryVisible.stories.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/structures/RoomStatusBarHistoryVisible.stories.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/structures/RoomStatusBarHistoryVisible.module.css
Outdated
Show resolved
Hide resolved
packages/shared-components/src/structures/RoomStatusBarHistoryVisible.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/structures/RoomStatusBarHistoryVisible.tsx
Outdated
Show resolved
Hide resolved
|
Converting to a draft for now while I consolidate the existing identity reset warnings. |
Shows a banner above the message composer whenever a user opens a room with non-join history visibility, which they can dismiss.
Issue: element-hq/element-meta#2875
Checklist
public/exportedsymbols have accurate TSDoc documentation.