-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Implement a shared Banner component.
#31266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kaylendog
wants to merge
6
commits into
element-hq:develop
Choose a base branch
from
kaylendog:kaylendog/shared-components/banner
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement a shared Banner component.
#31266
kaylendog
wants to merge
6
commits into
element-hq:develop
from
kaylendog:kaylendog/shared-components/banner
+597
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7e807d to
631a407
Compare
631a407 to
9fc03fd
Compare
This reverts commit 2c13354.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intend to use this in the consolidation of my implementation in #31156 for element-hq/element-meta#2875 and the existing
UserIdentityWarningsuch that they are reflective of the specified worst-case designs for history sharing UX.Checklist
public/exportedsymbols have accurate TSDoc documentation.