Upgrade to Poetry 2.2.1, PEP 621, and Python >=3.10#459
Open
Upgrade to Poetry 2.2.1, PEP 621, and Python >=3.10#459
Conversation
sandhose
force-pushed
the
quenting/modern-tooling/python-3.10
branch
2 times, most recently
from
09888d8 to
0a6e24f
Compare
sandhose
changed the title
sandhose
force-pushed
the
quenting/modern-tooling/python-3.10
branch
3 times, most recently
from
1215718 to
2ad3c6f
Compare
- Migrate pyproject.toml from [tool.poetry] to PEP 621 [project] table - Move dev dependencies to [dependency-groups] (PEP 735) - Bump minimum Python from 3.8 to 3.10 (3.8 and 3.9 are EOL) - Upgrade Poetry in CI from 1.2.2 to 2.2.1 - Update olddeps CI job to test on Python 3.10 - Fix sed in olddeps to skip requires-python line - Regenerate poetry.lock with Poetry 2.2.1
sandhose
force-pushed
the
quenting/modern-tooling/python-3.10
branch
from
2ad3c6f to
21c4d93
Compare
reivilibre
approved these changes
Apr 7, 2026
Contributor
reivilibre
left a comment
reivilibre
left a comment
There was a problem hiding this comment.
otherwise fine I think
| python-version: "3.10" | ||
| - name: Patch pyproject.toml to require oldest dependencies | ||
| run: | | ||
| # Ugly. Could use something like https://pyproject-parser.readthedocs.io/en/latest/cli.html#info in the future. |
Contributor
There was a problem hiding this comment.
I think comment should still apply
| run: | | ||
| # Ugly. Could use something like https://pyproject-parser.readthedocs.io/en/latest/cli.html#info in the future. | ||
| sed --in-place=.bak -e 's/>=/==/g' pyproject.toml | ||
| diff pyproject.toml.bak pyproject.toml || true # diff returns 1 if there is a change |
Contributor
There was a problem hiding this comment.
this comment should also stay
| ARG POETRY_VERSION | ||
| RUN --mount=type=cache,target=/root/.cache/uv \ | ||
| if [ -z "$TEST_ONLY_IGNORE_POETRY_LOCKFILE" ]; then \ | ||
| uvx --with poetry-plugin-export==1.8.0 \ |
Contributor
There was a problem hiding this comment.
I think this should stay pinned to a known-good version, it was like that for a reason iirc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlfrom[tool.poetry]to PEP 621[project]table[dependency-groups](PEP 735)POETRY_VERSIONto 2.2.1 and usepoetry-plugin-exportrequires-python[tool.poetry] packagesfor poetry-core module discovery[tool.ruff]before[tool.isort]to reduce churn in later PRsKnown limitations
requires-python = ">=3.10,<4"includes<4upper bound to satisfygoogle-auth-stubsPoetry resolution. Unusual but harmless.include = [{ path = "tests", format = "sdist" }]from the old config is dropped — tests are no longer bundled in the sdist.Test plan
poetry installworks with Poetry 2.2.1