Enable Glint by default for both JS and TS apps#273
Open
wagenet wants to merge 2 commits into
Open
Conversation
Implements RFC #976 (emberjs/rfcs#976): install and configure Glint v2 in blueprint output regardless of --typescript. JS apps get IDE tooling via jsconfig.json + the TypeScript Server plugin; TS apps get the full template type-check via the ember-tsc CLI. - Move @glint/ember-tsc, @glint/template, @glint/tsserver-plugin, @ember/app-tsconfig, and typescript out of the <% if (typescript) %> blocks in package.json so they install for both paths. - Add files/jsconfig.json for the JS path (extends @ember/app-tsconfig, noEmit:true). Filter it out for TS apps in index.js. - Stop excluding tsconfig.json's `types/` directory for JS apps — types/ is referenced by both jsconfig.json and tsconfig.json. The lint:types script remains TS-only (ember-tsc --noEmit). JS apps opt into editor tooling without a CLI type-check workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 2, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements RFC #976: Enable Glint by Default for the app blueprint. Glint v2 is now installed and configured for both TS and JS apps.
The blueprint already shipped Glint v2 packages — this PR moves them out of the `<% if (typescript) %>` blocks so JS apps benefit from editor tooling out of the box.
Related
Test plan
Note on archived predecessor
The earlier `embroider-build/app-blueprint` is archived; this PR is the same set of changes adapted for the new structure here.
🤖 Generated with Claude Code