i18n(fr): translate in French the 89 missing keys - #2464
Conversation
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Pull request overview
Adds French translations for previously-untranslated admin UI strings in the Lingui catalog, reducing English fallbacks in the fr locale.
Changes:
- Filled in many previously-empty
msgstrentries inpackages/admin/src/locales/fr/messages.po. - Added French translations for several BylineFilter/PluginManager/PortableTextEditor strings, including new pluralized ICU messages.
Suppressed comments (2)
packages/admin/src/locales/fr/messages.po:3869
- “Filter by byline” is currently translated identically to “Filter by author” (both “Filtrer par auteur”), which makes these two distinct filters indistinguishable in the UI. Use a distinct label for bylines (even if temporarily left as “byline”).
msgstr "Filtrer par auteur"
packages/admin/src/locales/fr/messages.po:938
- This sentence appears to mistranslate the original meaning (“byline linked to an entry’s author”) and reads ungrammatical/unclear (“l'auteur associé au propriétaire…”). Suggest rephrasing while keeping the “byline” concept distinct from “author”.
msgstr "Fait également correspondre l'auteur associé au propriétaire de l'entrée, lorsqu'aucun n'est attribué."
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
There was a problem hiding this comment.
This is a straightforward French translation PR: it fills in 89 previously-empty keys in packages/admin/src/locales/fr/messages.po, which is exactly the right shape for a translation change. I inspected the diff against the source strings and the French catalog. The translations are generally accurate, placeholders and plural forms are preserved, and product names/technical terms (MCP, robots.txt) are left untranslated as expected.
One translation introduces a real correctness problem:
example.comis localized toexemple.com.example.comis the IANA-reserved example domain (RFC 2606 / RFC 6761);exemple.comis not reserved and could point to a real site. A placeholder inside a self-signup domain input is a context where using a non-reserved domain is genuinely unsafe, so this should stayexample.com.
The author already notes in the PR description that “byline” and “authors” collide as “auteurs” and plans a follow-up PR to switch bylines to a different term (e.g. “collaborateur”). That collision is real and affects the newly-translated byline filter strings, but since it’s acknowledged and scoped to a follow-up, I’m not blocking on it here.
I also didn’t see a changeset for @emdash-cms/admin. CONTRIBUTING.md calls for one when a published package’s behavior changes; translation-only updates can reasonably be argued either way, but it’s worth confirming whether the maintainers want one added before merge.
Verdict: comment — one fix needed (exemple.com), otherwise clean.
Co-authored-by: emdashbot[bot] <273199577+emdashbot[bot]@users.noreply.github.com>
What does this PR do?
Translates in French the 89 missing keys.
Thanks to the new string in
src/components/BylineFilter.tsx:175, I noticed the French translation for "byline" clashes with the one for "authors". Since I had a single user, one section was never displayed on my side and I never noticed this was an issue. We'll need to use something else for "byline".I think "collaborateur" is what sounds the most natural in French (compared to "signature" for example, at least for "Guest byline"). As this means a lot of changes, I'll open a follow-up PR once this one is merged to fix that.
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change) (well, one test is failing... but unrelated to my changes:VitestBrowserElementError: Cannot find element with locator: page.getByText('5,200 installs'))pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output
N/A