Repository navigation
Add can_fd launch argument - #97
Merged
Merged
Conversation
openarm_hardware already reads a `can_fd` hardware parameter, but the launch files had no way to set it, so CAN 2.0 users had to edit them. Add a `can_fd` argument (default: true) to openarm.bimanual.launch.py and the bimanual MoveIt demo.launch.py and pass it to xacro alongside the CAN interface arguments.
demo.launch.py processes xacro twice: once for ros2_control_node and once via MoveItConfigsBuilder.robot_description() for move_group/RViz. Only the first one received the CAN mappings. Pass `can_fd`, `left_can_interface` and `right_can_interface` to both so the two robot descriptions stay consistent.
Collaborator
|
Thanks!
Please do it! |
kou
pushed a commit
that referenced
this pull request
Oct 6, 2026
Follow-up to #97, as discussed there. `openarm_bringup/README.md` still described the launch interface from before #91: - `openarm.launch.py` (single arm) no longer exists. `openarm.bimanual.launch.py` is the only launch file. - `hardware_type` and `can_interface` are no longer launch arguments. Fake vs. real hardware is `use_fake_hardware`, and each arm has its own `right_can_interface` / `left_can_interface`. - The `arm_type` default is now `openarm_v2.0`, not `v10`. - The Quick Start said "fake hardware" but passed `hardware_type:=real`. This updates the Quick Start (v2.0 with fake hardware, and v1.0 with real hardware), the launch file list and the parameter list. Every argument and default in the list matches what `openarm.bimanual.launch.py` declares. ## Test On ROS 2 Jazzy: - `ros2 launch openarm_bringup openarm.bimanual.launch.py`: both mock hardware interfaces load, and `joint_state_broadcaster`, both joint trajectory controllers and both gripper controllers are configured and activated. - `ros2 launch openarm_bringup openarm.bimanual.launch.py arm_type:=v10 use_fake_hardware:=false`: `OpenArmHW` loads with `CAN=can1, ..., can_fd=enabled`. No CAN device was attached, so it stops when it opens the socket. - `ros2 launch openarm_bringup openarm.bimanual.launch.py robot_controller:=forward_position_controller`: both forward position controllers are activated. ## Note I left `arm_prefix` out of the parameter list because setting it currently breaks controller loading. With `arm_prefix` set, `openarm.bimanual.launch.py` switches the controllers file to `openarm_bimanual_controllers_namespaced.yaml`. That file was removed in #91, when `openarm_v10_bimanual_controllers.yaml` was renamed to `openarm_bimanual_controllers.yaml`, and the namespaced variant wasn't re-added. For example, `ros2 launch openarm_bringup openarm.bimanual.launch.py arm_prefix:=leader` gives: ``` [WARNING] [launch_ros.actions.node]: Parameter file path is not a file: .../openarm_bringup/config/controllers/openarm_bimanual_controllers_namespaced.yaml [ERROR] [leader.controller_manager]: The 'type' param was not defined for 'joint_state_broadcaster'. [FATAL] [leader.spawner_joint_state_broadcaster]: Failed loading controller joint_state_broadcaster ``` I can fix that in a separate PR if that would help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65
Depends on enactic/openarm_description#78, which needs to be merged first.
Changes
can_fdlaunch argument (defaulttrue) toopenarm_bringup/launch/openarm.bimanual.launch.pyandopenarm_bimanual_moveit_config/launch/demo.launch.py, and pass it through xacro mappings.demo.launch.pyprocesses xacro twice: once withxacro.process_file()forros2_control_node, and once withMoveItConfigsBuilder.robot_description()formove_group/RViz. The second call didn't get any CAN mappings. Both now getcan_fd,left_can_interfaceandright_can_interface, so the two robot descriptions stay consistent.can_fdto the parameter list inopenarm_bringup/README.md.Test
I built
openarm_can,openarm_hardware,openarm_bringup,openarm_bimanual_moveit_configandopenarm_description(with #78) on ROS 2 Jazzy and ran the launch files withuse_fake_hardware:=false. No CAN device was attached, soOpenArmHWfails when it opens the socket, but it logs its parsed configuration first. For each launch I readrobot_descriptionwithros2 param get(from/robot_state_publisherfor bringup and from/move_groupfor the demo) and checked theOpenArmHWlog:ros2 launch ...(all withuse_fake_hardware:=false)robot_description: left / rightcan_interface,can_fdOpenArmHWlogopenarm_bringup openarm.bimanual.launch.py arm_type:=v10can1/can0,TrueCAN=can1, ..., can_fd=enabledopenarm_bringup openarm.bimanual.launch.py arm_type:=v10 can_fd:=falsecan1/can0,FalseCAN=can1, ..., can_fd=disabledopenarm_bringup openarm.bimanual.launch.py arm_type:=v20can1/can0,TrueCAN=can1, ..., can_fd=enabledopenarm_bringup openarm.bimanual.launch.py arm_type:=v20 can_fd:=false right_can_interface:=can2 left_can_interface:=can3can3/can2,FalseCAN=can3, ..., can_fd=disabledopenarm_bimanual_moveit_config demo.launch.py arm_type:=v10 can_fd:=false/move_group:can1/can0,FalseCAN=can1, ..., can_fd=disabledopenarm_bimanual_moveit_config demo.launch.py arm_type:=v20 can_fd:=false right_can_interface:=can2 left_can_interface:=can3/move_group:can3/can2,FalseCAN=can3, ..., can_fd=disabledOnly the left arm appears in the
OpenArmHWlog because its init fails first without a CAN device. The right arm's values come fromrobot_description.The
v10rows don't depend on #78, becauseopenarm_v10.urdf.xacrois unchanged there.pre-commit runpasses.Note
Other parts of
openarm_bringup/README.mdlook outdated: it mentionsopenarm.launch.py,hardware_typeandcan_interface, which no longer exist. I can update it in a separate PR if that would help.