Conversation
CT Test Results 2 files 74 suites 1h 9m 2s ⏱️ For more details on these failures, see this check. Results for commit 2a82abd. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
| do_srv_call(Node, Request, infinity) -> | ||
| rpc_check(catch gen_server:call({?NAME,Node}, Request, infinity)); | ||
| do_srv_call(Node, Request, Timeout) -> | ||
| Tag = make_ref(), | ||
| {Receiver,Mref} = | ||
| erlang:spawn_monitor( | ||
| fun() -> | ||
| %% Middleman process. Should be unsensitive to regular | ||
| %% exit signals. | ||
| process_flag(trap_exit, true), | ||
| Result = gen_server:call({?NAME,Node}, Request, Timeout), | ||
| exit({self(),Tag,Result}) | ||
| end), | ||
| receive | ||
| {'DOWN',Mref,_,_,{Receiver,Tag,Result}} -> | ||
| rpc_check(Result); | ||
| {'DOWN',Mref,_,_,Reason} -> | ||
| %% The middleman code failed. Or someone did | ||
| %% exit(_, kill) on the middleman process => Reason==killed | ||
| rpc_check_t({'EXIT',Reason}) |
There was a problem hiding this comment.
This seems to be a leftover from OTP pre-24, where you needed a middleman process to defend against late replies.
|
Thanks for all your work on getting rid of obsolete language constructs! It is much appreciated. We are getting very close to RC2. This PR will not make it into RC2 but we might consider it for inclusion in RC3, if we can determine that it is completely safe. From now on we will concentrate on bug fixes and fixing failed test cases. We will not include any removals of old-style |
You're welcome 😺
No hurry 😉 |
Co-authored-by: Jan Uhlig <juhlig@hnc-agency.org>
4 participants
This PR removes all deprecated old-style
catches from therpcmodule. The test suite didn't contain anycatches, but I fixed an export from call warning there.More comments inline.