Update Config Values to Match With the Latest Spec #5
Conversation
|
hm, the bootnode consistency check is .. unrelated. Can you take a quick look regardless? |
|
Could you please also adjust So we are as close to mainnet as possible. |
I am assuming this is a flake, not sure why it would fail with the current set of changes. A new run has been triggered for it |
I think there's a newline causing the fail? |
| @@ -93,15 +93,13 @@ DEPOSIT_CONTRACT_ADDRESS: 0x00000000219ab540356cBB839Cbe05303d7705Fa | |||
| # Networking | |||
| # --------------------------------------------------------------- | |||
| # `10 * 2**20` (= 10485760, 10 MiB) | |||
There was a problem hiding this comment.
| # `10 * 2**20` (= 10485760, 10 MiB) |
There was a problem hiding this comment.
Why do we want to remove this ?
| @@ -5,7 +5,7 @@ CONFIG_NAME: hoodi | |||
| # Genesis | |||
| # --------------------------------------------------------------- | |||
| # `2**14` (= 16,384) | |||
| MIN_GENESIS_ACTIVE_VALIDATOR_COUNT: 1000000 | |||
| MIN_GENESIS_ACTIVE_VALIDATOR_COUNT: 16384 | |||
There was a problem hiding this comment.
why are we changing this now? we already cut a rc yesterday which people might be running with the current value
There was a problem hiding this comment.
Just following this:
#5 (comment)
There was a problem hiding this comment.
Ok maybe it does not matter, looks like the only thing we do in Lodestar with MIN_GENESIS_ACTIVE_VALIDATOR_COUNT is "waiting for genesis validators" but since both values 16384 and 1000000 are fulfilled it should be fine to run with previous config
There was a problem hiding this comment.
thank you! approving and merging the PR then
…etwork config (#7594) This value will be updated by eth-clients/hoodi#5, this should be part of our next rc but it's a inconsequential change as both `MIN_GENESIS_ACTIVE_VALIDATOR_COUNT` values `1000000` vs. `16384` are already fulfilled by genesis state so "waiting for genesis validators" will not happen. this is the code I am talking about https://github.com/ChainSafe/lodestar/blob/f55be17bd3158f207402648da278db9560be7e91/packages/beacon-node/src/chain/genesis/genesis.ts#L140
In ethereum/consensus-specs#4045 , both
GOSSIP_MAX_SIZEandMAX_CHUNK_SIZEwere replaced withMAX_PAYLOAD_SIZE. This PR brings the hoodi config up to parity with the latest spec as ofv1.5.0-beta.3