Skip to content

fma: FMA for MT/64-bit Cannon #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 28, 2025
Merged

fma: FMA for MT/64-bit Cannon #123

merged 24 commits into from
Feb 28, 2025

Conversation

pauldowman
Copy link
Contributor

This is the failure modes analysis for multi-threaded & 64-bit Cannon.

@pauldowman pauldowman force-pushed the pauldowman/cannon-fma branch from 117c0bd to eded6d0 Compare October 11, 2024 17:08
@pauldowman
Copy link
Contributor Author

@Inphi @mbaxter I did rebase and force push this but I won't do that again so that we can share the branch if you want to make edits in here.

@Inphi Inphi force-pushed the pauldowman/cannon-fma branch from 417ef09 to db0efd3 Compare November 26, 2024 21:35
@Inphi Inphi marked this pull request as ready for review December 5, 2024 19:59
@Inphi
Copy link
Contributor

Inphi commented Dec 5, 2024

@pauldowman could you fill in the "Initial reviewers" and "Need approval from" fields in the table.

@Inphi Inphi changed the title fma: Draft FMA for MT/64-bit Cannon fma: FMA for MT/64-bit Cannon Dec 10, 2024
@Ethnical
Copy link
Contributor

Ethnical commented Dec 17, 2024

@Inphi For the failures that require monitoring like op-dispute-mon for the detection.
I would like to know if a scenario that exhaust or DoS op-program can also DoS the op-dispute-mon.
I am looking for case where we can crash the CHALLENGER and also the monitoring, thus making the game resolving incorrectly but impossible to detect and thus allowing an malicious actor to exploit the bridge.
In other words is there is part of the op-program code shared with op-dispute-mon.
I am thinking about case like Insufficient memory in the program or the Unimplemented syscalls or opcodes needed by op-program.

@pauldowman
Copy link
Contributor Author

Hooray, all resolved, and the vm-runner health check alert has been added. There's still the one open action item on here to add a dedicated Validation file for ensuring the absolute prestate is valid, but we agreed it's not blocking so I set the status to Final. Can we close it?

@Ethnical
Copy link
Contributor

Thanks a lot for the work there!
Yes, sound good to me to switch to FINAL here.
I have approved ✅

I will ask also @mds1 how long can we stay with the status implementing Action with the current process.

Copy link
Contributor

@Ethnical Ethnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!
The status of the FMA is set to FINAL.

@Ethnical Ethnical merged commit f095d1f into main Feb 28, 2025
@Ethnical Ethnical deleted the pauldowman/cannon-fma branch February 28, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants