refactor(fill): encapsulate fixture output options in FixtureOutput class
#1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Looks like this is not safe with pytest-xdist, see: Will take another look. |
This PR shouldn't have an issue with pytest-xdist, as it doesn't change the output directory behavior. It is and issue for #1473 though. |
8 tasks
danceratopz
force-pushed
the
refactor-fill-output
branch
from
6d5a92c to
9e9c26d
Compare
|
Does anyone use --flat-output? |
This was referenced May 15, 2025
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
… class (ethereum#1471) * refactor(fill): encapsulate fixture output ops in `FixtureOutput` class * docs: update changelog * refactor(fill): convert `FixtureOutput` to pydantic model * refactor(fill): move `FixtureOutput` class to its own moudule * test(fill): fix unit test * docs: Move changelog * fix: changelog --------- Co-authored-by: Mario Vega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR adds a
FixtureOutputclass (which inherits from pydanticBaseModel) tofiller.pyin order to encapsulatefiil's fixture JSON output-related settings. It's instantiated from the values of the command-line arguments that modify JSON output:--output,--flat-output,--single-fixture-per-file.🔗 Related Issues
Refactoring in preparation of:
✅ Checklist