Skip to content

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Apr 17, 2025

🗒️ Description

Requires:

Make fill's output behavior more robust: Do not write generated fixtures into an existing, non-empty output directory; it must now be empty or --clean must be used to delete it first.

Todo

  • Make directory deletion/creation multip-thread/pytest-xdist friendly.

🔗 Related Issues

Fixes #1030:

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@danceratopz
Copy link
Member Author

Closed in favor of #1608.

Should have force pushed, sorry for the noise.

@marioevz marioevz closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fill Scope: fill command type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(fill): insist that the output directory for generated JSON fixtures is initially empty
2 participants