feat(ui): add animated stat counters#624
Conversation
|
@Emelie-Dev is attempting to deploy a commit to the ezedikeevan's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Emelie-Dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ezedike-evan
left a comment
There was a problem hiding this comment.
Two things to fix before this can merge:
- Commit message —
Add animated stat countersdoesn't follow Conventional Commits. Please use a type prefix, e.g.feat(landing): add animated stat countersand push. - CI not triggered — no checks are running. Please push an empty commit or close and reopen to trigger GitHub Actions.
deb726f to
d769e95
Compare
|
Good day, I've updated the commit and pushed a new commit, but the GitHub Actions checks still aren't being triggered on my fork. |
ezedike-evan
left a comment
There was a problem hiding this comment.
Thanks for adding the conventional-commit prefix — almost there. Two remaining CI failures:
commitlint— the commit uses scopelanding, which isn't in the allowed scope list.landingisn't one of our tracked modules; please useuiinstead (e.g.feat(ui): add animated stat counters) and amend/force-push.lint-pr-title— the PR title "Add animated stat counters" also needs a Conventional Commits prefix, e.g.feat(ui): add animated stat counters. Please update the title to match.
Implementation itself (useCountUp hook, reduced-motion handling) looks good and matches #508 — just these two lint fixes needed.
d769e95 to
ab1d43f
Compare
The PR defined AnimatedStatValue and useCountUp but StatBar still rendered
the raw {value}, so the count-up never ran. Wire AnimatedStatValue into
the stat row.
closes #508