Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: np.float_ fixed #2592

Merged

Conversation

shamalgithub
Copy link
Contributor

changed the NDArray[np.float_] to NDArray[np.float64] to be compatible with Numpy version 2.0

@facebook-github-bot
Copy link
Contributor

Hi @shamalgithub!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Kerwin-Buijsman
Copy link

I manually changed the code in my installed Prophet package to solve the AttributeError: np.float_ error. It would be nice if this PR gets approved and the new changes are released :)

@pcpp94
Copy link

pcpp94 commented Jul 26, 2024

This is a bit of a hassle - can someone approve this PR?

@breimers
Copy link

Is there a planned release to PyPi of a new version with these changes?

@tisba
Copy link

tisba commented Sep 13, 2024

Sorry for the ping, @tcuongd, but there are so many issues for this issue and several open PRs to fix it… maybe we can get this one in somehow? Unless I'm overlooking something, this should be a rather trivial and save change.

@cameronbcote
Copy link

would this work?

numpy as np
np.float_ = np.float64

@WardBrian WardBrian merged commit 06d52b1 into facebook:main Sep 23, 2024
1 check passed
@tisba
Copy link

tisba commented Sep 25, 2024

Thanks for merging, @WardBrian. Is there any chance to get a release cut soonish? I couldn't find a milestone or something and it has been a while since the last release :)

@WardBrian
Copy link
Collaborator

I have commit rights but haven't run a release myself -- @tcuongd has been managing those, so let's ask him

@WardBrian
Copy link
Collaborator

@tcuongd I see a 1.1.6 here, but not on PyPI -- did the release successfully complete?

@tcuongd
Copy link
Collaborator

tcuongd commented Sep 30, 2024

It seems like PyPI has increased their security for releases. Github Actions now has to be added as a "trusted publisher" for the PyPI upload to work, which only the owners of the package (the original authors) can do. I've asked Ben, hopefully he gets back to us soon. In the meantime, the new binaries have been attached to the release note (https://github.com/facebook/prophet/releases/tag/v1.1.6-patched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants