Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-numpy-2.0-compatibility #2597

Closed

Conversation

lihangalex
Copy link

Fixed compatibility with NumPy 2.0 by replacing np.float_ with np.float64

Fixed compatibility with NumPy 2.0 by replacing np.float_ with np.float64
@facebook-github-bot
Copy link
Contributor

Hi @lihangalex!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@lihangalex lihangalex closed this Jul 12, 2024
@lihangalex lihangalex reopened this Jul 12, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@pufferfish42
Copy link

pufferfish42 commented Aug 1, 2024

Good work. Hope this PR will be merged soon. We are waiting for it.

@tisba
Copy link

tisba commented Sep 11, 2024

Duplicate of #2592

1 similar comment
@WardBrian
Copy link
Collaborator

Duplicate of #2592

@WardBrian WardBrian marked this as a duplicate of #2592 Sep 23, 2024
@WardBrian WardBrian closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants