Widen knip.json coverage and clean up dead code - #2290
Merged
Merged
Conversation
- Drop include allowlist entirely for full knip coverage (files, exports, types, unlisted, unresolved, duplicates all active); silence only actual false positives via ignoreDependencies and ignoreFiles - Remove dead AIParameterSlider component and AIParameterSliderProps type - Remove dead reasoningContentPubSub exports from pubSub.ts - Make modelConfig internal (only getModelConfig is used externally) - Remove dead setResponseHeadersIfNotSet/sendErrorResponse from streamUtils - Make DayCell/ActivityStats internal (sub-types of ActivityData, never imported directly) Resolves #2172.
felladrin
force-pushed
the
fix/knip-widen-coverage
branch
from
August 2, 2026 04:42
06405c4 to
d7c464b
Compare
felladrin
marked this pull request as ready for review
August 2, 2026 04:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Widen
knip.jsonfrom["dependencies"]to["dependencies", "files", "exports"]and clean up everything it surfaces.Changes
knip.jsonfilesandexportsdetection; addedignoreFilesfor convention-discovered configsAIParameterSlider.tsxAIParameterSliderPropstypes.ts— props type for the deleted componentreasoningContentPubSub+ 2 helperspubSub.ts— exported but never used in code (only docs)modelConfigconstinstead ofexport const) — onlygetModelConfig()is imported externallysetResponseHeadersIfNotSet,sendErrorResponsestreamUtils.ts— exported but never importedVerification
npx knip— zero findingsnpm run lint— all stages pass (biome, tsc, knip, jscpd, architectural, doc linters)npx vitest run— 334 tests pass