Code Quality: Refactored command titles and descritption for clarity and consistency #17146

Lukiluc29 · 2025-05-20T17:57:33Z

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Reviewed updated strings

Lukiluc29 · 2025-05-20T19:10:04Z

Normally, all the changes I had in mind have been implemented. It's up to you to tell me if everything suits you or if there are any changes to be made.

Copilot

Pull Request Overview

This PR refactors various UI command titles and subtitles to improve clarity and consistency across the Files application.

Updated labels and descriptions provide more context (e.g., specifying “in Windows Terminal,” “in the current view”).
Changes span multiple command strings to align wording and improve user comprehension.

Comments suppressed due to low confidence (3)

src/Files.App/Strings/en-US/Resources.resw:2439

Changing 'Cut' to 'Move' may alter the intended behavior; verify that the implementation aligns with this new terminology if the change is intentional.

<value>Move selected {0, plural, one {item} other {items}} to the clipboard</value>

src/Files.App/Strings/en-US/Resources.resw:3025

Changing 'Undo' to 'Revert' might modify the intended semantics of the command; please confirm that this wording accurately reflects the functionality.

<value>Revert the last file operation</value>

src/Files.App/Strings/en-US/Resources.resw:3028

Changing 'Redo' to 'Repeat' may lead to ambiguity in command behavior; verify that this change is consistent with the underlying functionality.

<value>Repeat the last file operation</value>

src/Files.App/Strings/en-US/Resources.resw

mdtauk · 2025-05-21T13:22:42Z

I am assuming we can't grab the name of the user's set default terminal, to make this string as accurate as we can.

Lukiluc29 · 2025-05-21T13:25:47Z

I am assuming we can't grab the name of the user's set default terminal, to make this string as accurate as we can.

No, currently it is just a fixed string

yaira2 · 2025-05-21T13:46:40Z

Just to clarify, actions have two strings.
Label/Title which is used in menus and tooltips.
Description which is used in the Command Palette.

yaira2 · 2025-05-25T15:18:58Z

src/Files.App/Strings/en-US/Resources.resw

@@ -130,7 +130,7 @@
    <value>Copy path with quotes</value>
  </data>
  <data name="CopyItemPathWithQuotes" xml:space="preserve">
-    <value>Copy selected item path with quotes</value>
+    <value>Copy item path with quotes</value>


selected helps provide a contrast with the action to copy the path of the current location.

I see what you mean. I removed the word "selected" because it wasn't useful to me. Also, the subtitle is there to properly describe the action, where it was correctly mentioned that it was only the selected item, and to shorten the title.

To reemphasize, Actions don't have subtitles. This is the label used in tooltips (if we ever expose this option on the toolbar).

src/Files.App/Strings/en-US/Resources.resw

yaira2 · 2025-05-25T15:22:52Z

src/Files.App/Strings/en-US/Resources.resw

@@ -2208,7 +2208,7 @@
    <value>Edit settings file</value>
  </data>
  <data name="EditSettingsFileDescription" xml:space="preserve">
-    <value>Open settings file in your default editor</value>
+    <value>Open the configuration file in a text editor</value>


Can you share info on the change from 'settings' to 'configuration'? I would also avoid the term 'a text editor' considering the file is not a text file.

We switched from "settings" to "configuration" because "configuration file" is the more common and precise term in technical contexts.
"Settings" usually refers to individual options or UI menus, while "configuration" covers the whole structure that defines how a system or program behaves.
Since we're talking about a file that controls the behavior of the application, "configuration file" felt more appropriate.
But I can revert "in a text editor" to return to "in your default editor".

src/Files.App/Strings/en-US/Resources.resw

yaira2 · 2025-05-25T15:26:01Z

src/Files.App/Strings/en-US/Resources.resw

@@ -2385,25 +2385,25 @@
    <value>Preview popup</value>
  </data>
  <data name="ToggleCompactOverlay" xml:space="preserve">
-    <value>Toggle compact overlay</value>
+    <value>Compact overlay</value>


What about compact overlay? 'Toggle' seems more appropriate.

This is simply the title of the action, and for me, it is enough to put "Compact Overlay", because "Toggle" does not give more information about the state of the mode. Also, since I removed it from the title, I left it in the subtitle to avoid repeating "Toggle" in the title and subtitle.

'Compact Overlay' sounds like it's switching to Compact Overlay.

left it in the subtitle to avoid repeating "Toggle" in the title and subtitle.

As mentioned earlier, we don't have subtitles.

src/Files.App/Strings/en-US/Resources.resw

yaira2 · 2025-05-25T15:27:25Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="ExitCompactOverlayDescription" xml:space="preserve">
-    <value>Exit compact overlay mode</value>
+    <value>Switch to normal overlay mode</value>


The app is either in "compact overlay mode' or not, 'normal overlay' isn't a mode.

What is the name of the mode when compact mode is not enabled? In this case, it is better to give it a name rather than saying "or not."

It doesn't really have a name, the window is either in the Compact Overlay state or not. The closest I can think of is 'Regular mode' of 'Full mode', but that doesn't really provide a lot of context.

yaira2 · 2025-05-25T15:28:21Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="EnterCompactOverlayDescription" xml:space="preserve">
-    <value>Enter compact overlay mode</value>
+    <value>Switch to compact overlay mode</value>


This change is good in theory, but it would be best to revert for consistency with 'Exit compact overlay'.

Yes, but this is consistent with "switch to normal overlay mode"

My view is that both should be reverted.

src/Files.App/Strings/en-US/Resources.resw

yaira2 · 2025-05-25T15:46:34Z

src/Files.App/Strings/en-US/Resources.resw

@@ -2736,19 +2736,19 @@
    <value>Close tabs other than selected tab</value>
  </data>
  <data name="CloseAllTabsDescription" xml:space="preserve">
-    <value>Close all tabs including the current tab</value>
+    <value>Close all open tabs including the current tab</value>


'Open' seems a bit redundant as you can't close a tab that's already closed 🙂

By extent: "all" logically includes "current" tab 🤓

@Jay-o-Way true, however this is to provide contrast with a similar action that does not close the current tab.

yaira2 · 2025-05-25T15:47:08Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="ReopenClosedTabDescription" xml:space="preserve">
-    <value>Reopen recently closed tab</value>
+    <value>Reopen the last closed tab</value>


This action isn't limited to the last tab.

Yes, but you won't open multiple tabs at once, only the last one. To reopen the last three, for example, run the action three times.

True, however the last closed tab was already reopened.

Yes, but we can't open a tab that is already open

'Last' seems to imply that after using the action once, it won't be available unless the user closes another tab. 'Recently' isn't perfect, but I don't feel that 'Last' is better for this.

src/Files.App/Strings/en-US/Resources.resw

Jay-o-Way

Just saying 😬

Jay-o-Way · 2025-05-29T13:32:30Z

src/Files.App/Strings/en-US/Resources.resw

@@ -2229,7 +2229,7 @@
    <value>Settings</value>
  </data>
  <data name="DoubleClickBlankSpaceToGoUp" xml:space="preserve">
-    <value>Double click on a blank space to go up one directory</value>
+    <value>Double-click a blank space to navigate one level up the folder tree</value>


"a blank space" makes it sound like "space" is a countable noun, like a space character.

Suggested change

<value>Double-click a blank space to navigate one level up the folder tree</value>

<value>Double-click blank space to navigate one level up the folder tree</value>

Jay-o-Way · 2025-05-29T13:37:21Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="LayoutDecreaseSizeDescription" xml:space="preserve">
-    <value>Decrease item size in the current view</value>
+    <value>Reduce the icon or item size in view</value>


Without context - the words "reduce size" go really well together. Just saying 😬

Jay-o-Way · 2025-05-29T13:39:42Z

src/Files.App/Strings/en-US/Resources.resw

@@ -2736,19 +2736,19 @@
    <value>Close tabs other than selected tab</value>
  </data>
  <data name="CloseAllTabsDescription" xml:space="preserve">
-    <value>Close all tabs including the current tab</value>
+    <value>Close all open tabs including the current tab</value>


By extent: "all" logically includes "current" tab 🤓

Jay-o-Way · 2025-05-29T13:41:55Z

src/Files.App/Strings/en-US/Resources.resw

@@ -3016,16 +3016,16 @@
    <value>Delete permanently</value>
  </data>
  <data name="DeleteItemPermanentlyDescription" xml:space="preserve">
-    <value>Delete selected {0, plural, one {item} other {items}} permanently</value>
+    <value>Delete selected {0, plural, one {item} other {items}} permanently without recovery</value>


Seems slightly redundant...

Jay-o-Way · 2025-05-29T13:42:49Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="PlayAllDescription" xml:space="preserve">
    <value>Play the selected media files</value>
  </data>
  <data name="UndoDescription" xml:space="preserve">
-    <value>Undo the last file operation</value>


I thought undo and redo were pretty common words.

Agreed, undo and redo are commonly used.

src/Files.App/Strings/en-US/Resources.resw

Lukiluc29 · 2025-05-29T16:11:46Z

For strings that are modified but used elsewhere than in actions, can we create new strings so that they are individual and thus make the recommended changes without any problems?

yaira2 · 2025-06-06T01:00:22Z

For strings that are modified but used elsewhere than in actions, can we create new strings so that they are individual and thus make the recommended changes without any problems?

Yes

yaira2 · 2025-06-08T21:15:57Z

src/Files.App/Strings/en-US/Resources.resw

@@ -3139,7 +3139,7 @@
    <value>Properties</value>
  </data>
  <data name="OpenClassicProperties" xml:space="preserve">
-    <value>Explorer properties</value>
+    <value>File Explorer properties</value>


As per @Jay-o-Way, this should start with 'Open'.

yaira2 · 2025-06-08T21:17:57Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="AddHorizontalPane" xml:space="preserve">
    <value>Horizontal pane</value>
  </data>
  <data name="AddHorizontalPaneDescription" xml:space="preserve">
-    <value>Add horizontal pane</value>
+    <value>Add a horizontal split pane</value>


'Horizonal' refers to the arrangement/orientation of the panes, we should avoid the term 'split' to prevent confusion.

yaira2 · 2025-06-08T21:20:09Z

src/Files.App/Strings/en-US/Resources.resw

@@ -3788,7 +3788,7 @@
    <value>Scroll to previous folder when navigating up</value>
  </data>
  <data name="NewWindowDescription" xml:space="preserve">
-    <value>Open new window</value>
+    <value>Open a new window instance</value>


instance is a bit redundant. I'm not against adding 'a', but it's worth considering that this will reset existing translations, and it might be best to just keep the current string.

yaira2 · 2025-06-08T21:20:29Z

src/Files.App/Strings/en-US/Resources.resw

@@ -3330,7 +3330,7 @@
    <value>Command Palette</value>
  </data>
  <data name="OpenCommandPaletteDescription" xml:space="preserve">
-    <value>Open Command Palette in the OmniBar</value>
+    <value>Open the Command Palette in the OmniBar</value>


@Jay-o-Way any thoughts?

yaira2 · 2025-06-08T21:24:01Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="OpenPropertiesDescription" xml:space="preserve">
-    <value>Open properties window</value>
+    <value>Open the properties window for selected item</value>


for selected item

It's a little more complex. This action also works when no items are selected, and it also works when multiple items are selected. We can make the text contextual in the future, but it's out of scope for this PR. For now, I would keep the added 'the' but remove 'for selected item'

yaira2 · 2025-06-08T21:24:15Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="RedoDescription" xml:space="preserve">
-    <value>Redo the last file operation</value>
+    <value>Repeat the last file operation</value>


Suggested change

<value>Repeat the last file operation</value>

<value>Redo the last file operation</value>

In other words "undo" 😆

yaira2 · 2025-06-08T21:24:22Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="PlayAllDescription" xml:space="preserve">
    <value>Play the selected media files</value>
  </data>
  <data name="UndoDescription" xml:space="preserve">
-    <value>Undo the last file operation</value>
+    <value>Revert the last file operation</value>


Suggested change

<value>Revert the last file operation</value>

<value>Undo the last file operation</value>

yaira2 · 2025-06-08T21:26:05Z

src/Files.App/Strings/en-US/Resources.resw

@@ -3016,16 +3016,16 @@
    <value>Delete permanently</value>
  </data>
  <data name="DeleteItemPermanentlyDescription" xml:space="preserve">
-    <value>Delete selected {0, plural, one {item} other {items}} permanently</value>
+    <value>Delete selected {0, plural, one {item} other {items}} without recovery</value>


@Lukiluc29 is there any reason to avoid the word 'permanently'? It accurately describes the operation and is consistent with the terminology in File Explorer.

yaira2 · 2025-06-08T21:26:58Z

src/Files.App/Strings/en-US/Resources.resw

@@ -3001,7 +3001,7 @@
    <value>Show checkboxes when selecting items</value>
  </data>
  <data name="EditPathDescription" xml:space="preserve">
-    <value>Edit path in the OmniBar</value>
+    <value>Edit the current folder path in the OmniBar</value>


Adding this comment for future reference (I need to think about this change);

yaira2 · 2025-06-08T21:28:04Z

src/Files.App/Strings/en-US/Resources.resw

+    <value>Switch to the previous tab</value>
  </data>
  <data name="NextTabDescription" xml:space="preserve">
-    <value>Move to the next tab</value>
+    <value>Switch to the next tab</value>


I'm not against these two changes, but they seem to be very similar to the existing strings. Is it worth resetting the translations for essentially the same string?

Actually go to is even better. "Switch" sounds like a setting or a control. https://learn.microsoft.com/en-us/style-guide/procedures-instructions/describing-interactions-with-ui

yaira2 · 2025-06-08T21:31:52Z

src/Files.App/Strings/en-US/Resources.resw

  </data>
  <data name="NavigateUpDescription" xml:space="preserve">
-    <value>Navigate up one directory</value>
+    <value>Navigate one level up in the folder tree</value>


@Jay-o-Way Navigate one level up in the folder tree vs Navigate one level up the folder tree?

Hm, tricky one, mostly looking at "navigate". That one is often used for websites and such. Simply saying "move one level up" sounds smoother. As for "in" or not, i would personally leave it out. Thinking of phrases like "move up a ladder".

In case of doubt, search MS Learn.

https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/f/folder-folder-icon
https://learn.microsoft.com/en-us/style-guide/procedures-instructions/describing-interactions-with-ui

We've been using the term 'navigate' for quite some time, so I'm not concerned about that part.

Lukiluc29 added 5 commits May 20, 2025 19:51

Update Resources.resw

c59a6a2

Changes of small details

27158c0

Same

f69d8ae

Add string

8b6ddda

Strings

6c84a29

yaira2 requested review from yaira2 and Copilot May 20, 2025 20:33

yaira2 added the needs - code review label May 20, 2025

Copilot AI reviewed May 20, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

Lukiluc29 added 2 commits May 21, 2025 07:26

Copilot suggestion

b18338f

Correction of a micro error

6815ede

Josh65-2201 reviewed May 21, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed May 25, 2025

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Show resolved Hide resolved

First changes

e98c33f

Jay-o-Way reviewed May 29, 2025

View reviewed changes

Lukiluc29 added 2 commits May 29, 2025 18:18

Suggestions

074ceb8

Other requested changes

ea5921d

Small changes

73ed7aa

Lukiluc29 changed the title ~~Code Quality: Refactored command titles and subtitles for clarity and consistency~~ Code Quality: Refactored command titles and descritption for clarity and consistency Jun 6, 2025

Lukiluc29 added 2 commits June 6, 2025 15:00

Error when changing

15e6634

More changes...

1561f94

yaira2 reviewed Jun 8, 2025

View reviewed changes

	<value>Double-click a blank space to navigate one level up the folder tree</value>
	<value>Double-click blank space to navigate one level up the folder tree</value>

	<value>Repeat the last file operation</value>
	<value>Redo the last file operation</value>

	<value>Revert the last file operation</value>
	<value>Undo the last file operation</value>

Uh oh!

Code Quality: Refactored command titles and descritption for clarity and consistency #17146

Are you sure you want to change the base?

Code Quality: Refactored command titles and descritption for clarity and consistency #17146

Uh oh!

Conversation

Lukiluc29 commented May 20, 2025

Uh oh!

Lukiluc29 commented May 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdtauk commented May 21, 2025

Uh oh!

Lukiluc29 commented May 21, 2025

Uh oh!

yaira2 commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yaira2 May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yaira2 May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yaira2 commented May 21, 2025 •

edited

Loading

yaira2 May 25, 2025 •

edited

Loading

yaira2 May 26, 2025 •

edited

Loading

yaira2 Jun 8, 2025 •

edited

Loading