Code Quality: Refactored command titles and descritption for clarity and consistency #17146
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -130,7 +130,7 @@ | |||||
| <value>Copy path with quotes</value> | ||||||
| </data> | ||||||
| <data name="CopyItemPathWithQuotes" xml:space="preserve"> | ||||||
| <value>Copy item path with quotes</value> | ||||||
| </data> | ||||||
| <data name="Browse" xml:space="preserve"> | ||||||
| <value>Browse</value> | ||||||
|
|
@@ -1086,13 +1086,13 @@ | |||||
| <value>Toggle the details pane to view basic file properties</value> | ||||||
| </data> | ||||||
| <data name="ToggleInfoPane" xml:space="preserve"> | ||||||
| <value>Info pane</value> | ||||||
| </data> | ||||||
| <data name="ToggleInfoPaneDescription" xml:space="preserve"> | ||||||
| <value>Toggle visibility of the detail/preview panes</value> | ||||||
| </data> | ||||||
| <data name="ToggleToolbar" xml:space="preserve"> | ||||||
| <value>Toolbar</value> | ||||||
| </data> | ||||||
| <data name="ToggleToolbarDescription" xml:space="preserve"> | ||||||
| <value>Toggle visibility of the toolbar</value> | ||||||
|
|
@@ -1917,7 +1917,7 @@ | |||||
| <value>Extract</value> | ||||||
| </data> | ||||||
| <data name="ExtractFiles" xml:space="preserve"> | ||||||
| <value>Extract items</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="ExtractHere" xml:space="preserve"> | ||||||
| <value>Extract here</value> | ||||||
|
|
@@ -2205,10 +2205,10 @@ | |||||
| <value>Recently used files is currently disabled in Windows File Explorer.</value> | ||||||
| </data> | ||||||
| <data name="EditSettingsFile" xml:space="preserve"> | ||||||
| <value>Edit configuration file</value> | ||||||
| </data> | ||||||
| <data name="EditSettingsFileDescription" xml:space="preserve"> | ||||||
| <value>Open the configuration file in a text editor</value> | ||||||
|
There was a problem hiding this comment. Can you share info on the change from 'settings' to 'configuration'? I would also avoid the term 'a text editor' considering the file is not a text file. There was a problem hiding this comment. We switched from "settings" to "configuration" because "configuration file" is the more common and precise term in technical contexts. |
||||||
| </data> | ||||||
| <data name="ReleaseNotes" xml:space="preserve"> | ||||||
| <value>Release Notes</value> | ||||||
|
|
@@ -2229,7 +2229,7 @@ | |||||
| <value>Settings</value> | ||||||
| </data> | ||||||
| <data name="DoubleClickBlankSpaceToGoUp" xml:space="preserve"> | ||||||
| <value>Double-click blank space to navigate one level up the folder tree</value> | ||||||
| </data> | ||||||
| <data name="ViewMore" xml:space="preserve"> | ||||||
| <value>View more</value> | ||||||
|
|
@@ -2385,25 +2385,25 @@ | |||||
| <value>Preview popup</value> | ||||||
| </data> | ||||||
| <data name="ToggleCompactOverlay" xml:space="preserve"> | ||||||
| <value>Compact overlay</value> | ||||||
|
There was a problem hiding this comment. What about compact overlay? 'Toggle' seems more appropriate. There was a problem hiding this comment. This is simply the title of the action, and for me, it is enough to put "Compact Overlay", because "Toggle" does not give more information about the state of the mode. Also, since I removed it from the title, I left it in the subtitle to avoid repeating "Toggle" in the title and subtitle. There was a problem hiding this comment. 'Compact Overlay' sounds like it's switching to Compact Overlay.
As mentioned earlier, we don't have subtitles. |
||||||
| </data> | ||||||
| <data name="OpenHelpDescription" xml:space="preserve"> | ||||||
| <value>Open the online help page in your browser</value> | ||||||
| </data> | ||||||
| <data name="ToggleFullScreenDescription" xml:space="preserve"> | ||||||
| <value>Toggle between full screen mode</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="EnterCompactOverlayDescription" xml:space="preserve"> | ||||||
| <value>Switch to compact overlay mode</value> | ||||||
|
There was a problem hiding this comment. This change is good in theory, but it would be best to revert for consistency with 'Exit compact overlay'. There was a problem hiding this comment. Yes, but this is consistent with "switch to normal overlay mode" There was a problem hiding this comment. My view is that both should be reverted. |
||||||
| </data> | ||||||
| <data name="ExitCompactOverlayDescription" xml:space="preserve"> | ||||||
| <value>Switch to normal overlay mode</value> | ||||||
|
There was a problem hiding this comment. The app is either in "compact overlay mode' or not, 'normal overlay' isn't a mode. There was a problem hiding this comment. What is the name of the mode when compact mode is not enabled? In this case, it is better to give it a name rather than saying "or not." There was a problem hiding this comment. It doesn't really have a name, the window is either in the Compact Overlay state or not. The closest I can think of is 'Regular mode' of 'Full mode', but that doesn't really provide a lot of context. |
||||||
| </data> | ||||||
| <data name="ToggleCompactOverlayDescription" xml:space="preserve"> | ||||||
| <value>Toggle compact overlay mode</value> | ||||||
| </data> | ||||||
| <data name="SearchDescription" xml:space="preserve"> | ||||||
| <value>Start a search in the OmniBar</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="ToggleShowHiddenItemsDescription" xml:space="preserve"> | ||||||
| <value>Toggle visibility of hidden items</value> | ||||||
|
|
@@ -2421,7 +2421,7 @@ | |||||
| <value>Toggle whether to show sidebar</value> | ||||||
| </data> | ||||||
| <data name="CopyItemDescription" xml:space="preserve"> | ||||||
| <value>Copy selected {0, plural, one {item} other {items}} to the clipboard</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="CopyPathDescription" xml:space="preserve"> | ||||||
| <value>Copy path of the current directory to the clipboard</value> | ||||||
|
|
@@ -2436,16 +2436,16 @@ | |||||
| <value>Copy path of the current directory with quotes to the clipboard</value> | ||||||
| </data> | ||||||
| <data name="CutItemDescription" xml:space="preserve"> | ||||||
| <value>Cut selected {0, plural, one {item} other {items}} to the clipboard</value> | ||||||
| </data> | ||||||
| <data name="PasteItemDescription" xml:space="preserve"> | ||||||
| <value>Paste clipboard items into the current folder</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="PasteShortcutDescription" xml:space="preserve"> | ||||||
| <value>Paste clipboard items into the current folder as shortcuts</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="PasteItemToSelectionDescription" xml:space="preserve"> | ||||||
| <value>Paste clipboard items into the selected folder</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="PasteToSelectedFolder" xml:space="preserve"> | ||||||
| <value>Paste to selected folder</value> | ||||||
|
|
@@ -2475,7 +2475,7 @@ | |||||
| <value>Restore all items from recycle bin</value> | ||||||
| </data> | ||||||
| <data name="OpenItemDescription" xml:space="preserve"> | ||||||
| <value>Open {0, plural, one {the selected item} other {selected items}}</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="OpenItemWithApplicationPickerDescription" xml:space="preserve"> | ||||||
| <value>Open {0, plural, one {item} other {items}} with selected application</value> | ||||||
|
|
@@ -2487,10 +2487,10 @@ | |||||
| <value>Refresh page contents</value> | ||||||
| </data> | ||||||
| <data name="RenameDescription" xml:space="preserve"> | ||||||
| <value>Change the name of the selected item</value> | ||||||
|
There was a problem hiding this comment. We've been using the term 'Rename' since that start of Files. There was a problem hiding this comment. The idea behind all these changes, as I explained earlier, is to avoid having an identical title and subtitle. So I understand that some sentences could be simplified, but otherwise, it would be pointless to have a title and subtitle containing the same sentence. There was a problem hiding this comment. Same as above, that said, we don't need duplicate strings in the resource file. If there are any duplicates, we can remove the extra one and reuse the string. |
||||||
| </data> | ||||||
| <data name="SelectAllDescription" xml:space="preserve"> | ||||||
| <value>Select all items in the current view</value> | ||||||
|
There was a problem hiding this comment. Is this any clearer than 'Select all items'? There was a problem hiding this comment. It's the same thing. This is to add more precision because last time, my grandmother thought she had selected all the files from the root of her key and told me that it would be better to put "in the current view" (and to avoid repetition with the title so I thought that in passing I could add precision to the description) There was a problem hiding this comment. If we move forward with the change, it will need to update based on the context (eg. pane, column). |
||||||
| </data> | ||||||
| <data name="InvertSelectionDescription" xml:space="preserve"> | ||||||
| <value>Invert selected items</value> | ||||||
|
|
@@ -2499,7 +2499,7 @@ | |||||
| <value>Clear selected items</value> | ||||||
| </data> | ||||||
| <data name="ToggleSelectDescription" xml:space="preserve"> | ||||||
| <value>Change selection of the focused item</value> | ||||||
| </data> | ||||||
| <data name="ShareItemDescription" xml:space="preserve"> | ||||||
| <value>Share selected {0, plural, one {file} other {files}} with others</value> | ||||||
|
|
@@ -2556,7 +2556,7 @@ | |||||
| <value>Run selected PowerShell script</value> | ||||||
| </data> | ||||||
| <data name="LaunchPreviewPopupDescription" xml:space="preserve"> | ||||||
| <value>Show item preview in a popup window</value> | ||||||
| </data> | ||||||
| <data name="CompressIntoArchiveDescription" xml:space="preserve"> | ||||||
| <value>Create archive with selected {0, plural, one {item} other {items}}</value> | ||||||
|
|
@@ -2583,19 +2583,19 @@ | |||||
| <value>Rotate selected {0, plural, one {image} other {images}} to the right</value> | ||||||
| </data> | ||||||
| <data name="OpenSettingsDescription" xml:space="preserve"> | ||||||
| <value>Open the application settings page</value> | ||||||
|
There was a problem hiding this comment. Is the term 'application' helpful? Perhaps 'Open the settings page' would be better. There was a problem hiding this comment. This is more specific as it can be confusing with Windows Settings, as Windows is often mentioned in the app from what I've seen. There was a problem hiding this comment. I'd like to check that, do you remember where it is mentioned? |
||||||
| </data> | ||||||
| <data name="OpenTerminalDescription" xml:space="preserve"> | ||||||
| <value>Open folder in Windows Terminal</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="OpenTerminalAsAdminDescription" xml:space="preserve"> | ||||||
| <value>Open folder in Windows Terminal with administrator rights</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="LayoutDecreaseSizeDescription" xml:space="preserve"> | ||||||
| <value>Reduce the icon or item size in view</value> | ||||||
|
There was a problem hiding this comment. 'Decrease' and 'Increase' seem to be more commonly used for these scenarios. There was a problem hiding this comment. Without context - the words "reduce size" go really well together. Just saying 😬 |
||||||
| </data> | ||||||
| <data name="LayoutIncreaseSizeDescription" xml:space="preserve"> | ||||||
| <value>Enlarge the icon or item size in view</value> | ||||||
| </data> | ||||||
| <data name="LayoutDetailsDescription" xml:space="preserve"> | ||||||
| <value>Switch to details view</value> | ||||||
|
|
@@ -2619,7 +2619,7 @@ | |||||
| <value>Switch to columns view</value> | ||||||
| </data> | ||||||
| <data name="LayoutAdaptiveDescription" xml:space="preserve"> | ||||||
| <value>Switch to adjusting layout </value> | ||||||
| </data> | ||||||
| <data name="SortByNameDescription" xml:space="preserve"> | ||||||
| <value>Sort items by name</value> | ||||||
|
|
@@ -2700,19 +2700,19 @@ | |||||
| <value>Toggle group sort direction</value> | ||||||
| </data> | ||||||
| <data name="NewTabDescription" xml:space="preserve"> | ||||||
| <value>Open a new tab in the same window</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="NavigateBackDescription" xml:space="preserve"> | ||||||
| <value>Navigate to the previous location</value> | ||||||
| </data> | ||||||
| <data name="NavigateForwardDescription" xml:space="preserve"> | ||||||
| <value>Navigate to the next location</value> | ||||||
| </data> | ||||||
| <data name="NavigateUpDescription" xml:space="preserve"> | ||||||
| <value>Navigate one level up in the folder tree</value> | ||||||
|
There was a problem hiding this comment. @Jay-o-Way There was a problem hiding this comment. Hm, tricky one, mostly looking at "navigate". That one is often used for websites and such. Simply saying "move one level up" sounds smoother. As for "in" or not, i would personally leave it out. Thinking of phrases like "move up a ladder". In case of doubt, search MS Learn. https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/f/folder-folder-icon There was a problem hiding this comment. We've been using the term 'navigate' for quite some time, so I'm not concerned about that part. |
||||||
| </data> | ||||||
| <data name="DuplicateCurrentTabDescription" xml:space="preserve"> | ||||||
| <value>Duplicate the current tab</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="DuplicateSelectedTabDescription" xml:space="preserve"> | ||||||
| <value>Duplicate selected tab</value> | ||||||
|
|
@@ -2736,19 +2736,19 @@ | |||||
| <value>Close tabs other than selected tab</value> | ||||||
| </data> | ||||||
| <data name="CloseAllTabsDescription" xml:space="preserve"> | ||||||
| <value>Close all open tabs including the current tab</value> | ||||||
|
There was a problem hiding this comment. 'Open' seems a bit redundant as you can't close a tab that's already closed 🙂 There was a problem hiding this comment. By extent: "all" logically includes "current" tab 🤓 There was a problem hiding this comment. @Jay-o-Way true, however this is to provide contrast with a similar action that does not close the current tab. |
||||||
| </data> | ||||||
| <data name="ReopenClosedTabDescription" xml:space="preserve"> | ||||||
| <value>Reopen the last closed tab</value> | ||||||
|
There was a problem hiding this comment. This action isn't limited to the last tab. There was a problem hiding this comment. Yes, but you won't open multiple tabs at once, only the last one. To reopen the last three, for example, run the action three times. There was a problem hiding this comment. True, however the last closed tab was already reopened. There was a problem hiding this comment. Yes, but we can't open a tab that is already open There was a problem hiding this comment. 'Last' seems to imply that after using the action once, it won't be available unless the user closes another tab. 'Recently' isn't perfect, but I don't feel that 'Last' is better for this. |
||||||
| </data> | ||||||
| <data name="PreviousTabDescription" xml:space="preserve"> | ||||||
| <value>Switch to the previous tab</value> | ||||||
| </data> | ||||||
| <data name="NextTabDescription" xml:space="preserve"> | ||||||
| <value>Switch to the next tab</value> | ||||||
|
Comment on lines
+2745
to
+2748
There was a problem hiding this comment. I'm not against these two changes, but they seem to be very similar to the existing strings. Is it worth resetting the translations for essentially the same string? There was a problem hiding this comment. Actually go to is even better. "Switch" sounds like a setting or a control. https://learn.microsoft.com/en-us/style-guide/procedures-instructions/describing-interactions-with-ui |
||||||
| </data> | ||||||
| <data name="CloseSelectedTabDescription" xml:space="preserve"> | ||||||
| <value>Close the current tab</value> | ||||||
Lukiluc29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </data> | ||||||
| <data name="CloseActivePaneDescription" xml:space="preserve"> | ||||||
| <value>Close the active pane</value> | ||||||
|
|
@@ -3001,7 +3001,7 @@ | |||||
| <value>Show checkboxes when selecting items</value> | ||||||
| </data> | ||||||
| <data name="EditPathDescription" xml:space="preserve"> | ||||||
| <value>Edit the current folder path in the OmniBar</value> | ||||||
|
There was a problem hiding this comment. Adding this comment for future reference (I need to think about this change); |
||||||
| </data> | ||||||
| <data name="AddItemDescription" xml:space="preserve"> | ||||||
| <value>Create new item</value> | ||||||
|
|
@@ -3016,16 +3016,16 @@ | |||||
| <value>Delete permanently</value> | ||||||
| </data> | ||||||
| <data name="DeleteItemPermanentlyDescription" xml:space="preserve"> | ||||||
| <value>Delete selected {0, plural, one {item} other {items}} without recovery</value> | ||||||
|
There was a problem hiding this comment. @Lukiluc29 is there any reason to avoid the word 'permanently'? It accurately describes the operation and is consistent with the terminology in File Explorer. |
||||||
| </data> | ||||||
| <data name="PlayAllDescription" xml:space="preserve"> | ||||||
| <value>Play the selected media files</value> | ||||||
| </data> | ||||||
| <data name="UndoDescription" xml:space="preserve"> | ||||||
|
There was a problem hiding this comment. I thought undo and redo were pretty common words. There was a problem hiding this comment. Agreed, undo and redo are commonly used. |
||||||
| <value>Revert the last file operation</value> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| </data> | ||||||
| <data name="RedoDescription" xml:space="preserve"> | ||||||
| <value>Repeat the last file operation</value> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| </data> | ||||||
| <data name="Location" xml:space="preserve"> | ||||||
| <value>Location:</value> | ||||||
|
|
@@ -3139,10 +3139,10 @@ | |||||
| <value>Properties</value> | ||||||
| </data> | ||||||
| <data name="OpenClassicProperties" xml:space="preserve"> | ||||||
| <value>File Explorer properties</value> | ||||||
|
There was a problem hiding this comment. As per @Jay-o-Way, this should start with 'Open'. |
||||||
| </data> | ||||||
| <data name="OpenPropertiesDescription" xml:space="preserve"> | ||||||
| <value>Open the properties window for selected item</value> | ||||||
|
There was a problem hiding this comment.
It's a little more complex. This action also works when no items are selected, and it also works when multiple items are selected. We can make the text contextual in the future, but it's out of scope for this PR. For now, I would keep the added 'the' but remove 'for selected item' |
||||||
| </data> | ||||||
| <data name="OpenClassicPropertiesDescription" xml:space="preserve"> | ||||||
| <value>Open File Explorer properties window</value> | ||||||
|
|
@@ -3330,7 +3330,7 @@ | |||||
| <value>Command Palette</value> | ||||||
| </data> | ||||||
| <data name="OpenCommandPaletteDescription" xml:space="preserve"> | ||||||
| <value>Open the Command Palette in the OmniBar</value> | ||||||
|
|
||||||
| </data> | ||||||
| <data name="ShortcutItemWorkingDir" xml:space="preserve"> | ||||||
| <value>Start in:</value> | ||||||
|
|
@@ -3788,7 +3788,7 @@ | |||||
| <value>Scroll to previous folder when navigating up</value> | ||||||
| </data> | ||||||
| <data name="NewWindowDescription" xml:space="preserve"> | ||||||
| <value>Open a new window instance</value> | ||||||
|
There was a problem hiding this comment.
|
||||||
| </data> | ||||||
| <data name="ChangeAlbumCover" xml:space="preserve"> | ||||||
| <value>Change album cover</value> | ||||||
|
|
@@ -4019,13 +4019,13 @@ | |||||
| <value>Vertical pane</value> | ||||||
| </data> | ||||||
| <data name="AddVerticalPaneDescription" xml:space="preserve"> | ||||||
| <value>Add a vertical split pane</value> | ||||||
| </data> | ||||||
| <data name="AddHorizontalPane" xml:space="preserve"> | ||||||
| <value>Horizontal pane</value> | ||||||
| </data> | ||||||
| <data name="AddHorizontalPaneDescription" xml:space="preserve"> | ||||||
| <value>Add a horizontal split pane</value> | ||||||
|
There was a problem hiding this comment. 'Horizonal' refers to the arrangement/orientation of the panes, we should avoid the term 'split' to prevent confusion. |
||||||
| </data> | ||||||
| <data name="ArrangePanesVertically" xml:space="preserve"> | ||||||
| <value>Arrange vertically</value> | ||||||
|
|
@@ -4226,4 +4226,4 @@ | |||||
| <data name="OmnibarSearchModeTextPlaceholder" xml:space="preserve"> | ||||||
| <value>Search for files and folders...</value> | ||||||
| </data> | ||||||
| </root> | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selectedhelps provide a contrast with the action to copy the path of the current location.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. I removed the word "selected" because it wasn't useful to me. Also, the subtitle is there to properly describe the action, where it was correctly mentioned that it was only the selected item, and to shorten the title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reemphasize, Actions don't have subtitles. This is the label used in tooltips (if we ever expose this option on the toolbar).