chore(dart): Use published pub.dev versions for Firebase dependencies#1276
Conversation
…dev instead of using git dependencies and dependency_overrides. Updates apply to quickstarts `callable-functions`, `callable-functions-streaming`, `https-time-server`, and `resize-image`. Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request transitions several Dart quickstarts from git-based dependencies to published versions (^0.5.0) for firebase_functions, firebase_admin_sdk, and google_cloud_firestore, while cleaning up dependency overrides. Feedback indicates that in the callable-functions-streaming, callable-functions, and resize-image modules, firebase_admin_sdk and google_cloud_firestore were removed from overrides but not added to the dependencies list, which may result in build failures if the code relies on these packages.
| git: | ||
| url: https://github.com/firebase/firebase-functions-dart | ||
| ref: main | ||
| firebase_functions: ^0.5.0 |
There was a problem hiding this comment.
The pull request description states that firebase_admin_sdk and google_cloud_firestore should be updated to their published ^0.5.0 versions. While these were removed from the dependency_overrides section, they were not added to the dependencies section in this file. This will likely cause build failures if the code depends on these packages, as they are no longer pulled in transitively from the git version of firebase_functions.
firebase_functions: ^0.5.0
firebase_admin_sdk: ^0.5.0
google_cloud_firestore: ^0.5.0| git: | ||
| url: https://github.com/firebase/firebase-functions-dart | ||
| ref: main | ||
| firebase_functions: ^0.5.0 |
There was a problem hiding this comment.
The pull request description states that firebase_admin_sdk and google_cloud_firestore should be updated to their published ^0.5.0 versions. While these were removed from the dependency_overrides section, they were not added to the dependencies section in this file. This will likely cause build failures if the code depends on these packages, as they are no longer pulled in transitively from the git version of firebase_functions.
firebase_functions: ^0.5.0
firebase_admin_sdk: ^0.5.0
google_cloud_firestore: ^0.5.0| git: | ||
| url: https://github.com/firebase/firebase-functions-dart | ||
| ref: main | ||
| firebase_functions: ^0.5.0 |
There was a problem hiding this comment.
The pull request description states that firebase_admin_sdk and google_cloud_firestore should be updated to their published ^0.5.0 versions. While these were removed from the dependency_overrides section, they were not added to the dependencies section in this file. This will likely cause build failures if the code depends on these packages, as they are no longer pulled in transitively from the git version of firebase_functions.
firebase_functions: ^0.5.0
firebase_admin_sdk: ^0.5.0
google_cloud_firestore: ^0.5.0
This PR replaces the
gitdependencies anddependency_overridesblocks in all Dart quickstartpubspec.yamlfiles with the published^0.5.0versions forfirebase_functions,firebase_admin_sdk, andgoogle_cloud_firestorefrom pub.dev.PR created automatically by Jules for task 17143255474696196670 started by @jhuleatt