Skip to content

chore(dart): Use published pub.dev versions for Firebase dependencies#1276

Merged
jhuleatt merged 1 commit into
dart-launchfrom
update-dart-pubspec-dependencies-17143255474696196670
Apr 17, 2026
Merged

chore(dart): Use published pub.dev versions for Firebase dependencies#1276
jhuleatt merged 1 commit into
dart-launchfrom
update-dart-pubspec-dependencies-17143255474696196670

Conversation

@jhuleatt
Copy link
Copy Markdown
Collaborator

This PR replaces the git dependencies and dependency_overrides blocks in all Dart quickstart pubspec.yaml files with the published ^0.5.0 versions for firebase_functions, firebase_admin_sdk, and google_cloud_firestore from pub.dev.


PR created automatically by Jules for task 17143255474696196670 started by @jhuleatt

…dev instead of using git dependencies and dependency_overrides. Updates apply to quickstarts `callable-functions`, `callable-functions-streaming`, `https-time-server`, and `resize-image`.

Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions several Dart quickstarts from git-based dependencies to published versions (^0.5.0) for firebase_functions, firebase_admin_sdk, and google_cloud_firestore, while cleaning up dependency overrides. Feedback indicates that in the callable-functions-streaming, callable-functions, and resize-image modules, firebase_admin_sdk and google_cloud_firestore were removed from overrides but not added to the dependencies list, which may result in build failures if the code relies on these packages.

git:
url: https://github.com/firebase/firebase-functions-dart
ref: main
firebase_functions: ^0.5.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description states that firebase_admin_sdk and google_cloud_firestore should be updated to their published ^0.5.0 versions. While these were removed from the dependency_overrides section, they were not added to the dependencies section in this file. This will likely cause build failures if the code depends on these packages, as they are no longer pulled in transitively from the git version of firebase_functions.

  firebase_functions: ^0.5.0
  firebase_admin_sdk: ^0.5.0
  google_cloud_firestore: ^0.5.0

git:
url: https://github.com/firebase/firebase-functions-dart
ref: main
firebase_functions: ^0.5.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description states that firebase_admin_sdk and google_cloud_firestore should be updated to their published ^0.5.0 versions. While these were removed from the dependency_overrides section, they were not added to the dependencies section in this file. This will likely cause build failures if the code depends on these packages, as they are no longer pulled in transitively from the git version of firebase_functions.

  firebase_functions: ^0.5.0
  firebase_admin_sdk: ^0.5.0
  google_cloud_firestore: ^0.5.0

git:
url: https://github.com/firebase/firebase-functions-dart
ref: main
firebase_functions: ^0.5.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description states that firebase_admin_sdk and google_cloud_firestore should be updated to their published ^0.5.0 versions. While these were removed from the dependency_overrides section, they were not added to the dependencies section in this file. This will likely cause build failures if the code depends on these packages, as they are no longer pulled in transitively from the git version of firebase_functions.

  firebase_functions: ^0.5.0
  firebase_admin_sdk: ^0.5.0
  google_cloud_firestore: ^0.5.0

@jhuleatt jhuleatt merged commit 8d61692 into dart-launch Apr 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant