Skip to content

chore(dart): Use published pub.dev versions for Firebase dependencies #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhuleatt merged 1 commit into from
Apr 17, 2026
Merged

chore(dart): Use published pub.dev versions for Firebase dependencies #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions Dart/quickstarts/callable-functions-streaming/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,9 @@ environment:
sdk: ^3.11.0

dependencies:
firebase_functions:
git:
url: https://github.com/firebase/firebase-functions-dart
ref: main
firebase_functions: ^0.5.0
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description states that firebase_admin_sdk and google_cloud_firestore should be updated to their published ^0.5.0 versions. While these were removed from the dependency_overrides section, they were not added to the dependencies section in this file. This will likely cause build failures if the code depends on these packages, as they are no longer pulled in transitively from the git version of firebase_functions.

  firebase_functions: ^0.5.0
  firebase_admin_sdk: ^0.5.0
  google_cloud_firestore: ^0.5.0

http: ^1.2.0

dev_dependencies:
build_runner: ^2.10.5
lints: ^6.0.0

dependency_overrides:
firebase_functions:
git:
url: https://github.com/firebase/firebase-functions-dart
ref: main
firebase_admin_sdk:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/firebase_admin_sdk
ref: main
google_cloud_firestore:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/google_cloud_firestore
ref: main
21 changes: 1 addition & 20 deletions Dart/quickstarts/callable-functions/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,8 @@ environment:
sdk: ^3.11.0

dependencies:
firebase_functions:
git:
url: https://github.com/firebase/firebase-functions-dart
ref: main
firebase_functions: ^0.5.0
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description states that firebase_admin_sdk and google_cloud_firestore should be updated to their published ^0.5.0 versions. While these were removed from the dependency_overrides section, they were not added to the dependencies section in this file. This will likely cause build failures if the code depends on these packages, as they are no longer pulled in transitively from the git version of firebase_functions.

  firebase_functions: ^0.5.0
  firebase_admin_sdk: ^0.5.0
  google_cloud_firestore: ^0.5.0


dev_dependencies:
build_runner: ^2.10.5
lints: ^6.0.0

dependency_overrides:
firebase_functions:
git:
url: https://github.com/firebase/firebase-functions-dart
ref: main
firebase_admin_sdk:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/firebase_admin_sdk
ref: main
google_cloud_firestore:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/google_cloud_firestore
ref: main
29 changes: 3 additions & 26 deletions Dart/quickstarts/https-time-server/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,34 +6,11 @@ environment:
sdk: ^3.11.0

dependencies:
firebase_functions:
git:
url: https://github.com/firebase/firebase-functions-dart
ref: main
firebase_admin_sdk:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/firebase_admin_sdk
ref: main
google_cloud_firestore:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/google_cloud_firestore
ref: main
firebase_functions: ^0.5.0
firebase_admin_sdk: ^0.5.0
google_cloud_firestore: ^0.5.0
intl: ^0.20.2

dev_dependencies:
build_runner: ^2.10.5
lints: ^6.0.0

dependency_overrides:
firebase_admin_sdk:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/firebase_admin_sdk
ref: main
google_cloud_firestore:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/google_cloud_firestore
ref: main
17 changes: 1 addition & 16 deletions Dart/quickstarts/resize-image/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,9 @@ environment:
dependencies:
image: ^4.8.0
path: ^1.9.1
firebase_functions:
git:
url: https://github.com/firebase/firebase-functions-dart
ref: main
firebase_functions: ^0.5.0
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description states that firebase_admin_sdk and google_cloud_firestore should be updated to their published ^0.5.0 versions. While these were removed from the dependency_overrides section, they were not added to the dependencies section in this file. This will likely cause build failures if the code depends on these packages, as they are no longer pulled in transitively from the git version of firebase_functions.

  firebase_functions: ^0.5.0
  firebase_admin_sdk: ^0.5.0
  google_cloud_firestore: ^0.5.0

intl: ^0.20.2

dev_dependencies:
build_runner: ^2.10.5
lints: ^6.0.0

dependency_overrides:
firebase_admin_sdk:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/firebase_admin_sdk
ref: main
google_cloud_firestore:
git:
url: https://github.com/firebase/firebase-admin-dart
path: packages/google_cloud_firestore
ref: main
Loading