chore: improve error logging #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we cannot open a log file, print its file name too. This is handy when a user skips the log filename accidently, e.g., runs t3 -- /bin/echo foo.
limeytexan
requested changes
Apr 7, 2025
There was a problem hiding this comment.
Would be happy to merge with one small modification.
Thanks @maximkonovalov for the suggestion!
| @@ -498,7 +498,8 @@ int main(int argc, char *argv[]) { | |||
|
|
|||
| FILE *logfile = fopen(logfile_name, "w"); | |||
| if (!logfile) { | |||
| perror("Error opening logfile"); | |||
| fprintf(stderr, "Error opening logfile %s %s\n", logfile_name, | |||
There was a problem hiding this comment.
Good idea!
Previously, the error message appeared like this:
% ./result-t3/bin/t3 -t /not/found -- sh -c "echo err 1>&2; echo out"
Error opening logfile: No such file or directory
So the only change I'd make would be to keep the formatting closer to the original and use single quotes surrounding the filename:
Suggested change
| fprintf(stderr, "Error opening logfile %s %s\n", logfile_name, | |
| fprintf(stderr, "Error opening logfile '%s': %s\n", logfile_name, |
With this version the error looks like this:
% ./result-t3/bin/t3 -t /not/found -- sh -c "echo err 1>&2; echo out"
Error opening logfile '/not/found': No such file or directory
Of course! Please go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we cannot open a log file, print its file name too. This is handy when a user skips the log filename accidently, e.g., runs t3 -- /bin/echo foo.