Skip to content

chore: improve error logging #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: improve error logging #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion t3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,8 @@ int main(int argc, char *argv[]) {

FILE *logfile = fopen(logfile_name, "w");
if (!logfile) {
perror("Error opening logfile");
fprintf(stderr, "Error opening logfile %s %s\n", logfile_name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Previously, the error message appeared like this:

% ./result-t3/bin/t3 -t /not/found -- sh -c "echo err 1>&2; echo out"
Error opening logfile: No such file or directory

So the only change I'd make would be to keep the formatting closer to the original and use single quotes surrounding the filename:

Suggested change
fprintf(stderr, "Error opening logfile %s %s\n", logfile_name,
fprintf(stderr, "Error opening logfile '%s': %s\n", logfile_name,

With this version the error looks like this:

% ./result-t3/bin/t3 -t /not/found -- sh -c "echo err 1>&2; echo out"
Error opening logfile '/not/found': No such file or directory

strerror(errno));
return EXIT_FAILURE;
}

Expand Down