out_es: Prevent a SIGSEGV when ctx->index is NULL #10353
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkennedy1-godaddy
force-pushed
the
es-sigsegv-on-null-ptr
branch
from
d3257c8 to
97f4915
Compare
|
configuration: (this will fail) service:
flush: 1
daemon: off
pipeline:
inputs:
- name: forward
unix_path: /var/run/fluent.sock
tag: log
outputs:
- name: es
match: *
host: valid_host
port: valid_port
index:
suppress_type_name: true
trace_error: true
tls: trueconfiguration: (this will work) service:
flush: 1
daemon: off
pipeline:
inputs:
- name: forward
unix_path: /var/run/fluent.sock
tag: log
outputs:
- name: es
match: *
host: valid_host
port: valid_port
index: any-index
suppress_type_name: true
trace_error: true
tls: true |
|
Debug log with failing configuration: |
|
Log from successful configuration: |
|
valgrind: |
This was referenced May 19, 2025
|
Probably worth adding a simple unit test to exercise the check and also prevent future regressions. Does the opensearch output have the same issue? If so we should fix it too |
|
Yeah looks like opensearch needs the fix too. For some reason the run code analysis script is causing the out_elastic tests to be skipped, but it is running the opensearch ones (and the code is the same between them on this case). Running the test suite one last time to validate the change and then i'll push and fix the commit message as well. |
If `index` field is blank in the configuration, and `Logstash_Format` and `Generate_ID` are both `off`, a SIGSEGV can occur when trying to generate the index for a set of messages. Signed-off-by: Todd Kennedy <[email protected]>
tkennedy1-godaddy
force-pushed
the
es-sigsegv-on-null-ptr
branch
from
0c81ebd to
8705833
Compare
tkennedy1-godaddy
requested review from
leonardo-albertovich,
fujimotos and
koleini
as code owners
3 tasks
|
@patrick-stephens the fix for opensearch is in #10365. Do you want me to replicate the artifacts (output logs, configuration, etc) in that PR as well, or is the similarity enough in the platforms/tests? |
tkennedy1-godaddy
changed the title
This indicates that some of the part of Fluent Bit should cause memory leaks. |
For completeness I would replicate or at least link but I think you've done that already? Main thing is if we look at the PR in isolation is it complete enough. |
|
@cosmo0920 I did not since my change causes fluent-bit to exit early and allocates no objects nor changes any data or structures. it seems if there are leaks this change would not have introduced them (unless there was something else I was supposed to call instead of however, here is the log from that. |
cosmo0920
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
indexfield is blank in the configuration, andLogstash_FormatandGenerate_IDare bothoff, a SIGSEGV can occur when trying to generate the index for a set of messages.Fixes #10339
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.