VP-211: subtitlesFinder component for a VideoPlayer#125
VP-211: subtitlesFinder component for a VideoPlayer#125anvk wants to merge 28 commits intofluid-project:mainfrom
Conversation
…niSubComponent. Based on the acheetham branch https://github.com/acheetham/videoPlayer/tree/FLUID-4851
…l so that transcripts and captions use different data. Make it work. Filter languages which we get from Amara so that local captions/transcripts will have a higher priority.
…video source. Component always creates itself.
… available languages and uses them.
…and transcripts if nothing got retrieved from Amara.
Updated the known issues section of the README with some more issues that came up during release testing.
…ration test to reflect that. Also removing timeout from the integration test.
Conflicts: js/VideoPlayer_controllers.js
…ality to handle relative paths.
…s to accommodate those changes.
…subtitlesFinder testing.
…toring its tests.
…ubtitlesFinder and its DataSet component.
There was a problem hiding this comment.
Not sure why these are in a model, instead of plain default options.
There was a problem hiding this comment.
Because those values could be changed potentially. There could be the case when the same dataSource would be used to query 2 different webservices. In that case we want to change those values and according to our conventions options block has settings which do not change when state of the component changes
|
|
6 participants
NOTE: Alex's pull request before leaving. This pull request needs a code review.
http://issues.fluidproject.org/browse/VP-211