VP-211: subtitlesFinder component for a VideoPlayer #125
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| Copyright 2012 OCAD University | ||
|
|
||
| Licensed under the Educational Community License (ECL), Version 2.0 or the New | ||
| BSD license. You may not use this file except in compliance with one these | ||
| Licenses. | ||
|
|
||
| You may obtain a copy of the ECL 2.0 License and BSD License at | ||
| https://github.com/fluid-project/infusion/raw/master/Infusion-LICENSE.txt | ||
| */ | ||
|
|
||
| /*global jQuery, window, fluid*/ | ||
|
|
||
| // JSLint options | ||
| /*jslint white: true, funcinvoke: true, undef: true, newcap: true, nomen: true, regexp: true, bitwise: true, browser: true, forin: true, maxerr: 100, indent: 4 */ | ||
|
|
||
| (function () { | ||
|
|
||
| fluid.defaults("fluid.dataSource", { | ||
| gradeNames: ["autoInit", "fluid.eventedComponent", "fluid.modelComponent"], | ||
| events: { | ||
| onError: null, | ||
| onSuccess: null | ||
| }, | ||
| invokers: { | ||
| get: "fluid.dataSource.get", | ||
| dataParse: { | ||
|
Member
There was a problem hiding this comment. this can be written simply as: |
||
| funcName: "fluid.dataSource.dataParse", | ||
| args: ["{arguments}.0"] | ||
| } | ||
| }, | ||
| model: { | ||
|
Member
There was a problem hiding this comment. Not sure why these are in a model, instead of plain default options.
Member
Author
There was a problem hiding this comment. Because those values could be changed potentially. There could be the case when the same dataSource would be used to query 2 different webservices. In that case we want to change those values and according to our conventions options block has settings which do not change when state of the component changes |
||
| dataType: "jsonp", // Default ajax data type | ||
| params: {}, // parameters which will be added to the url | ||
| baseURL: null // url where the call will be made | ||
| }, | ||
| timeout: 10000 // do not allow jsonp to halt. max timeout request | ||
|
Member
Author
There was a problem hiding this comment. It is mandatory for jsonp requests. By default they could query indefinitely. |
||
| }); | ||
|
|
||
| fluid.dataSource.dataParse = function (data) { | ||
|
Member
There was a problem hiding this comment. if this is how the function looks like, default invoker implementation should be fluid.identity. |
||
| return data; | ||
| }; | ||
|
|
||
| fluid.dataSource.get = function (that) { | ||
| var events = that.events, | ||
| model = that.model; | ||
|
|
||
| $.ajax({ | ||
| dataType: /* "jsonp", */model.dataType, | ||
| url: model.baseURL, | ||
| data: model.params, | ||
| timeout : that.options.timeout | ||
| }).done(function (data) { | ||
| events.onSuccess.fire(that.dataParse(data)); | ||
|
Member
There was a problem hiding this comment. Perhaps we should parse on a separate line to have a possibility of seeing the result. |
||
| }).fail(function () { | ||
| events.onError.fire(); | ||
| }); | ||
| }; | ||
|
|
||
| })(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright data should be 2013