Skip to content

Conversation

AbdeMohlbi
Copy link
Contributor

@AbdeMohlbi AbdeMohlbi commented Sep 30, 2025

edits the android example to follow the suggestions to convert the code to kotlin in docs

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@AbdeMohlbi AbdeMohlbi changed the title WIP [flutter_plugin_android_lifecycle] Update Android example to use Kotlin DSL syntax Oct 11, 2025
@AbdeMohlbi
Copy link
Contributor Author

hi @reidbaker i do not think requires a version bump/edits to changelog WDYT ?

@AbdeMohlbi AbdeMohlbi requested a review from reidbaker October 11, 2025 17:20
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also link flutter/flutter#176065 since some of this work is for kotlin conversion.

Finally consider adding a check + test in https://github.com/flutter/packages/blob/main/script/tool/lib/src/gradle_check_command.dart for changes we want to enforce across the repo.

versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
applicationId = "io.flutter.plugins.flutter_plugin_android_lifecycle_example"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines do not need a version bump.

id "dev.flutter.flutter-gradle-plugin"
}

def localProperties = new Properties()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to show our work on why this deletion is safe. I think the best way to show that publicly would be to file an issue that says to delete these lines. Then also shows your work for why this is safe to delete preferably with links to prs that took this code from required to not required. Then in this pr link that bug as related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants