Skip to content

[flutter_plugin_android_lifecycle] Update Android example to use Kotlin DSL syntax #10136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[flutter_plugin_android_lifecycle] Update Android example to use Kotlin DSL syntax #10136

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8e8bed
Update build.gradle
AbdeMohlbi Sep 30, 2025
c608576
Update build.gradle
AbdeMohlbi Sep 30, 2025
f460bf3
Merge branch 'main' into AbdeMohlbi_flutter_plugin_android_lifecycle
AbdeMohlbi Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 8 additions & 28 deletions packages/flutter_plugin_android_lifecycle/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,37 +4,17 @@ plugins {
id "dev.flutter.flutter-gradle-plugin"
}

def localProperties = new Properties()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to show our work on why this deletion is safe. I think the best way to show that publicly would be to file an issue that says to delete these lines. Then also shows your work for why this is safe to delete preferably with links to prs that took this code from required to not required. Then in this pr link that bug as related.

def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
localPropertiesFile.withReader('UTF-8') { reader ->
localProperties.load(reader)
}
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
flutterVersionCode = '1'
}

def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
flutterVersionName = '1.0'
}


android {
compileSdk = flutter.compileSdkVersion


defaultConfig {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "io.flutter.plugins.flutter_plugin_android_lifecycle_example"
minSdkVersion flutter.minSdkVersion
targetSdkVersion flutter.targetSdkVersion
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
applicationId = "io.flutter.plugins.flutter_plugin_android_lifecycle_example"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines do not need a version bump.

minSdk = flutter.minSdkVersion
targetSdk = flutter.targetSdkVersion
versionCode = flutter.versionCode
versionName = flutter.versionName
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
}

buildTypes {
Expand All @@ -46,12 +26,12 @@ android {
}
namespace = "io.flutter.plugins.flutter_plugin_android_lifecycle_example"
lint {
disable 'InvalidPackage'
disable += "InvalidPackage"
}
}

flutter {
source = '../..'
source = "../.."
}

dependencies {
Expand Down