Skip to content

[shared_preferences] Switch to Kotlin Pigeon#11661

Open
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:kotlin-pigeon-shared-prefs
Open

[shared_preferences] Switch to Kotlin Pigeon#11661
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:kotlin-pigeon-shared-prefs

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and updates API signatures and number handling for Kotlin/Java generator differences.

Part of flutter/flutter#158287

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and
updates API signatures and number handling for Kotlin/Java generator
differences.

Part of flutter/flutter#158287
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the internal implementation of the shared_preferences_android package from Java-generated Pigeon code to Kotlin-generated Pigeon code. The LegacySharedPreferencesPlugin has been updated to use primitive types and the new Kotlin companion setup methods. Additionally, the pigeon dependency is bumped to version 26.3.4, and autogenerated files in Dart and Kotlin are updated with improved equality, hashing, and error-handling utilities. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant