Skip to content

[shared_preferences] Switch to Kotlin Pigeon #11661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stuartmorgan-g wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[shared_preferences] Switch to Kotlin Pigeon #11661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/shared_preferences/shared_preferences_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.4.24

* Updates internal implementation to use Kotlin Pigeon.

## 2.4.23

* Fixes dartdoc comments that accidentally used HTML.
Expand Down
21 changes: 10 additions & 11 deletions ...oid/src/main/java/io/flutter/plugins/sharedpreferences/LegacySharedPreferencesPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import androidx.annotation.VisibleForTesting;
import io.flutter.embedding.engine.plugins.FlutterPlugin;
import io.flutter.plugin.common.BinaryMessenger;
import io.flutter.plugins.sharedpreferences.Messages.SharedPreferencesApi;
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
Expand Down Expand Up @@ -56,7 +55,7 @@ public LegacySharedPreferencesPlugin() {
private void setUp(@NonNull BinaryMessenger messenger, @NonNull Context context) {
preferences = context.getSharedPreferences(SHARED_PREFERENCES_NAME, Context.MODE_PRIVATE);
try {
SharedPreferencesApi.setUp(messenger, this);
SharedPreferencesApi.Companion.setUp(messenger, this);
} catch (Exception ex) {
Log.e(TAG, "Received exception while setting up SharedPreferencesPlugin", ex);
}
Expand All @@ -69,16 +68,16 @@ public void onAttachedToEngine(@NonNull FlutterPlugin.FlutterPluginBinding bindi

@Override
public void onDetachedFromEngine(@NonNull FlutterPlugin.FlutterPluginBinding binding) {
SharedPreferencesApi.setUp(binding.getBinaryMessenger(), null);
SharedPreferencesApi.Companion.setUp(binding.getBinaryMessenger(), null);
}

@Override
public @NonNull Boolean setBool(@NonNull String key, @NonNull Boolean value) {
public boolean setBool(@NonNull String key, boolean value) {
return preferences.edit().putBoolean(key, value).commit();
}

@Override
public @NonNull Boolean setString(@NonNull String key, @NonNull String value) {
public boolean setString(@NonNull String key, @NonNull String value) {
// TODO (tarrinneal): Move this string prefix checking logic to dart code and make it an
// Argument Error.
if (value.startsWith(LIST_IDENTIFIER)
Expand All @@ -92,31 +91,31 @@ public void onDetachedFromEngine(@NonNull FlutterPlugin.FlutterPluginBinding bin
}

@Override
public @NonNull Boolean setInt(@NonNull String key, @NonNull Long value) {
public boolean setInt(@NonNull String key, long value) {
return preferences.edit().putLong(key, value).commit();
}

@Override
public @NonNull Boolean setDouble(@NonNull String key, @NonNull Double value) {
public boolean setDouble(@NonNull String key, double value) {
String doubleValueStr = Double.toString(value);
return preferences.edit().putString(key, DOUBLE_PREFIX + doubleValueStr).commit();
}

@Override
public @NonNull Boolean remove(@NonNull String key) {
public boolean remove(@NonNull String key) {
return preferences.edit().remove(key).commit();
}

@Override
public @NonNull Boolean setEncodedStringList(@NonNull String key, @NonNull String value)
public boolean setEncodedStringList(@NonNull String key, @NonNull String value)
throws RuntimeException {
return preferences.edit().putString(key, value).commit();
}

// Deprecated, for testing purposes only.
@Deprecated
@Override
public @NonNull Boolean setDeprecatedStringList(@NonNull String key, @NonNull List<String> value)
public boolean setDeprecatedStringList(@NonNull String key, @NonNull List<String> value)
throws RuntimeException {
return preferences.edit().putString(key, LIST_IDENTIFIER + listEncoder.encode(value)).commit();
}
Expand All @@ -129,7 +128,7 @@ public void onDetachedFromEngine(@NonNull FlutterPlugin.FlutterPluginBinding bin
}

@Override
public @NonNull Boolean clear(@NonNull String prefix, @Nullable List<String> allowList)
public boolean clear(@NonNull String prefix, @Nullable List<String> allowList)
throws RuntimeException {
SharedPreferences.Editor clearEditor = preferences.edit();
Map<String, ?> allPrefs = preferences.getAll();
Expand Down
Loading
Loading