Always use XML builders to construct XML #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
Jun 13, 2024
| @@ -27,6 +27,17 @@ def save | |||
| def shutdown | |||
| service.destroy_network(uuid) | |||
| end | |||
|
|
|||
| def to_xml | |||
There was a problem hiding this comment.
Further testing told me save isn't even implemented now so I'm not too worried about this.
The Pool class doesn't have a to_xml method so this is unused.
This removes the use of ERB to construct XML and instead always uses a builder.
ekohl
force-pushed
the
drop-erb-template-rendering
branch
from
738f4ef
to
476c630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of ERB to construct XML and instead always uses a builder.
The primary motivation was that the ERB invocation was raising an error and an XML builder guarantees valid XML. While doing this I figured out that at least Pool doesn't have a .to_xml and Network.to_xml was just broken. Pool.to_xml does work, but it is noted in the docs (https://libvirt.org/formatstorage.html) that some fileds (
allocation,capacity&available) are not applicable when creating a pool so it's questionable if they should be included.Given that, I question if anyone actually uses this in practice, so I'm not too worried about breaking things.