Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use XML builders to construct XML #135

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Always use XML builders to construct XML #135

merged 4 commits into from
Jul 15, 2024

Commits on Jul 15, 2024

  1. Remove unused pool XML template 

    The Pool class doesn't have a to_xml method so this is unused.
    @ekohl
    ekohl committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    09b6851 View commit details
    Browse the repository at this point in the history

  2. Add a test for Network#to_xml

    @ekohl
    ekohl committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b073ac7 View commit details
    Browse the repository at this point in the history

  3. Add test for Volume#to_xml

    @ekohl
    ekohl committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4ea420c View commit details
    Browse the repository at this point in the history

  4. Always use XML builders to construct XML 

    This removes the use of ERB to construct XML and instead always uses a
builder.
    @ekohl
    ekohl committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    476c630 View commit details
    Browse the repository at this point in the history