Switching to new implementation / non fork version of https://github.com/golang/term/pull/20 #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allyAdd in AddToHistory()
…odd to add/expose something that isn't actually used/needed
ldemailly
force-pushed
the
testing_expose_history_try_2
branch
from
7c04ad4 to
736980f
Compare
ldemailly
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR switches from the forked term package to the official golang.org/x/term implementation while introducing a new history management approach using TermHistory.
- Replaces old history functions with a new TermHistory struct and corresponding methods.
- Updates the Open function and history API calls in terminal.go.
- Introduces a new panic command in the demo and modifies benchmark loops in tests.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| terminal.go | Migrates to golang.org/x/term and refactors history management. |
| example/main.go | Adds a panic command and updates terminal closure logging. |
| ansipixels/ansipixels.go | Updates term import to golang.org/x/term. |
| ansipixels/ansiclean_test.go | Changes benchmark loop iteration method. |
| README.md | Updates documentation to reflect switching to golang.org/x/term. |
Files not reviewed (2)
- Makefile: Language not supported
- go.mod: Language not supported
| @@ -135,7 +135,7 @@ func TestAnsiCleanHR(t *testing.T) { | |||
| func BenchmarkAnsiCleanRE(b *testing.B) { | |||
| for _, tc := range testCases { | |||
| b.Run(tc.name, func(b *testing.B) { | |||
| for i := 0; i < b.N; i++ { | |||
| for range b.N { | |||
There was a problem hiding this comment.
Using 'for range b.N' is invalid because b.N is an integer. Use a standard for loop such as 'for i := 0; i < b.N; i++ {' instead.
Suggested change
| for range b.N { | |
| for i := 0; i < b.N; i++ { |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For golang/term#20 / updated golang/go#68780
Note the Add/UnconditionallyAdd is a bit awkward