term: support pluggable history #20

ldemailly · 2025-03-21T06:17:43Z

Expose a new History interface that allows replacement of the default
ring buffer to customize what gets added or not; as well as to allow
saving/restoring history on either the default ringbuffer or a custom
replacement.

Fixes golang/go#68780

gopherbot · 2025-03-21T06:24:12Z

This PR (HEAD: b9f8be7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/659835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-21T06:31:43Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-21T06:39:15Z

This PR (HEAD: 6b01958) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/659835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-21T07:46:10Z

This PR (HEAD: fe1e3a4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/659835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-21T08:25:30Z

Message from Laurent Demailly:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-21T08:33:49Z

This PR (HEAD: a5f4981) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/659835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-21T16:06:26Z

This PR (HEAD: bad1ef1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/659835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-21T17:08:31Z

Message from Ian Lance Taylor:

Patch Set 7: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-02T21:32:07Z

This PR (HEAD: 13c58aa) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/659835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

…ethods

…odd to add/expose something that isn't actually used/needed

gopherbot · 2025-04-16T20:49:09Z

This PR (HEAD: ba6dd5c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/659835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-16T21:23:20Z

Message from Laurent Demailly:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-16T21:57:35Z

Message from Sean Liao:

Patch Set 10:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-16T22:04:56Z

This PR (HEAD: 5e07c15) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/659835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-16T22:12:15Z

Message from Laurent Demailly:

Patch Set 10:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T11:28:16Z

Message from Michael Pratt:

Patch Set 17: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T14:57:10Z

Message from Jorropo:

Patch Set 17:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T14:57:11Z

Message from Jorropo:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T15:04:59Z

Message from Jorropo:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T17:29:53Z

Message from Laurent Demailly:

Patch Set 17:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T17:42:58Z

Message from Laurent Demailly:

Patch Set 17:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:39:40Z

Message from Jorropo:

Patch Set 17:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:46:27Z

This PR (HEAD: 6212813) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/659835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-18T18:53:09Z

Message from Laurent Demailly:

Patch Set 17:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:59:54Z

Message from Jorropo:

Patch Set 18: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:59:54Z

Message from Go LUCI:

Patch Set 18:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-18T18:48:46Z","revision":"4a14adcb4d9366152a31670b8176408ed3c3e4bf"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:59:55Z

Message from Jorropo:

Patch Set 18: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:59:55Z

Message from Go LUCI:

Patch Set 18:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:59:56Z

Message from Go LUCI:

Patch Set 18: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:59:57Z

Message from Jorropo:

Patch Set 18: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:59:57Z

Message from Go LUCI:

Patch Set 18:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-18T18:51:26Z","revision":"4a14adcb4d9366152a31670b8176408ed3c3e4bf"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T18:59:58Z

Message from Jorropo:

Patch Set 18: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T19:06:49Z

Message from Jorropo:

Patch Set 18: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-18T19:06:49Z

Message from Go LUCI:

Patch Set 18:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-21T17:55:02Z

Message from Austin Clements:

Patch Set 18: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-21T19:24:37Z

Message from Michael Pratt:

Patch Set 18: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

Expose a new History interface that allows replacement of the default ring buffer to customize what gets added or not; as well as to allow saving/restoring history on either the default ringbuffer or a custom replacement. Fixes golang/go#68780 Change-Id: I7e61dc6bb438749c8502223705518ef8ff9025b4 GitHub-Last-Rev: 6212813 GitHub-Pull-Request: #20 Reviewed-on: https://go-review.googlesource.com/c/term/+/659835 Reviewed-by: Michael Pratt <[email protected]> Auto-Submit: Jorropo <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Jorropo <[email protected]> Reviewed-by: Austin Clements <[email protected]>

gopherbot · 2025-04-21T19:31:15Z

Message from Go LUCI:

Patch Set 18:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-21T19:18:18Z","revision":"4a14adcb4d9366152a31670b8176408ed3c3e4bf"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-21T19:31:16Z

Message from Michael Pratt:

Patch Set 18: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-21T19:31:16Z

Message from Go LUCI:

Patch Set 18:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/659835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-21T19:38:18Z

This PR is being closed because golang.org/cl/659835 has been merged.

…85) * Test/new implementation for golang/term#20 * better name and expose this history impl * Expose the AutoHistory as a field/simplify - also use the UnconditionallyAdd in AddToHistory() * fix bug with autohistory state * Use latest version of term PR and demo ability to output in At() as well * Adding Len() per latest comment on proposal - even though it's a bit odd to add/expose something that isn't actually used/needed * use the 2 calls version * Make linters happy; return update size errors * commented out but tested panic in History test * No more fork - 🎉

ldemailly added a commit to fortio/terminal that referenced this pull request Mar 21, 2025

Test/new implementation for golang/term#20

4568c19

ldemailly mentioned this pull request Mar 21, 2025

Switching to new implementation / non fork version of https://github.com/golang/term/pull/20 fortio/terminal#85

Merged

ldemailly mentioned this pull request Mar 21, 2025

x/term: support pluggable history golang/go#68780

Closed

ldemailly mentioned this pull request Apr 16, 2025

x/term: add history APIs. #15

Closed

ldemailly changed the title ~~x/term: exposing history based on proposal discussion~~ x/term: support pluggable history Apr 16, 2025

ldemailly added 7 commits April 16, 2025 13:41

x/term: exposing history based on golang/go#68780 (comment)

2a4d303

Update NthPreviousEntry->At in godoc too

c4cef2d

Need unlock before History.Add()

c892a3a

Tweak the godoc

93da400

Also allow output in History.At - and protect from panic in History m…

c52ccb7

…ethods

Adding Len() per latest comment on proposal - even though it's a bit …

a068581

…odd to add/expose something that isn't actually used/needed

Update to accepted version - At panics()

ba6dd5c

ldemailly force-pushed the expose_history_try_2 branch from 13c58aa to ba6dd5c Compare April 16, 2025 20:47

ldemailly added a commit to fortio/terminal that referenced this pull request Apr 16, 2025

Test/new implementation for golang/term#20

c65e486

ldemailly changed the title ~~x/term: support pluggable history~~ term: support pluggable history Apr 16, 2025

Review updates

5e07c15

Review comments

6212813

gopherbot closed this Apr 21, 2025

ldemailly mentioned this pull request Apr 21, 2025

Indicate this is not needed anymore fortio/term#10

Merged

term: support pluggable history #20

term: support pluggable history #20

Conversation

ldemailly commented Mar 21, 2025 • edited by dmitshur Loading

gopherbot commented Mar 21, 2025

gopherbot commented Mar 21, 2025

gopherbot commented Mar 21, 2025

gopherbot commented Mar 21, 2025

gopherbot commented Mar 21, 2025

gopherbot commented Mar 21, 2025

gopherbot commented Mar 21, 2025

gopherbot commented Mar 21, 2025

gopherbot commented Apr 2, 2025

gopherbot commented Apr 16, 2025

gopherbot commented Apr 16, 2025

gopherbot commented Apr 16, 2025

gopherbot commented Apr 16, 2025

gopherbot commented Apr 16, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 18, 2025

gopherbot commented Apr 21, 2025

gopherbot commented Apr 21, 2025

gopherbot commented Apr 21, 2025

gopherbot commented Apr 21, 2025

gopherbot commented Apr 21, 2025

gopherbot commented Apr 21, 2025

ldemailly commented Mar 21, 2025 •

edited by dmitshur

Loading